test: Increase btrfs loopback device size to 128MB#2448
Merged
mlaventure merged 1 commit intocontainerd:masterfrom Jul 9, 2018
Merged
test: Increase btrfs loopback device size to 128MB#2448mlaventure merged 1 commit intocontainerd:masterfrom
mlaventure merged 1 commit intocontainerd:masterfrom
Conversation
With btrfs-prog 4.17 as shipped with Alpine 3.8 the btrfs tests
fail with:
ERROR: '/dev/loop1' is too small to make a usable filesystem
ERROR: minimum size for each btrfs device is 114294784
btrfs-prog commit 997f9977c243 ("btrfs-progs: mkfs: Prevent
temporary system chunk to use space in reserved 1M range")
changed the code to compute the minimum size for a btrfs size
and is the likely reason for this error.
Increase the size of the loop back device to 128MB for
the btrfs test.
With this fix, the containerd tests pass on Alpine 3.8,
tested in LinuxKit with kernel 4.14.53.
fixes containerd#2447
Signed-off-by: Rolf Neugebauer <[email protected]>
Contributor
Author
|
If accepted, it would be good to cherry-pick this into 1.1. In LinuxKit we track the |
Codecov Report
@@ Coverage Diff @@
## master #2448 +/- ##
=======================================
Coverage 45.01% 45.01%
=======================================
Files 92 92
Lines 9414 9414
=======================================
Hits 4238 4238
Misses 4493 4493
Partials 683 683
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Jul 8, 2018
ijc
approved these changes
Jul 9, 2018
Member
|
LGTM |
mlaventure
approved these changes
Jul 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With btrfs-prog 4.17 as shipped with Alpine 3.8 the btrfs tests
fail with:
ERROR: '/dev/loop1' is too small to make a usable filesystem
ERROR: minimum size for each btrfs device is 114294784
btrfs-prog commit 997f9977c243 ("btrfs-progs: mkfs: Prevent
temporary system chunk to use space in reserved 1M range")
changed the code to compute the minimum size for a btrfs size
and is the likely reason for this error.
Increase the size of the loop back device to 128MB for
the btrfs test.
With this fix, the containerd tests pass on Alpine 3.8,
tested in LinuxKit with kernel 4.14.53.
fixes #2447
Signed-off-by: Rolf Neugebauer [email protected]