split content service gRPC package#2441
split content service gRPC package#2441AkihiroSuda wants to merge 1 commit intocontainerd:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2441 +/- ##
=======================================
Coverage 44.73% 44.73%
=======================================
Files 93 93
Lines 9501 9501
=======================================
Hits 4250 4250
Misses 4566 4566
Partials 685 685
Continue to review full report at Codecov.
|
|
This also seems useful for #2415 I am not a fan of the package name |
AkihiroSuda
force-pushed
the
expose-cs-grpc
branch
from
abc09ff to
afc96a6
Compare
|
renamed to |
|
@dmcgowan PTAL? |
There was a problem hiding this comment.
Could you add some documentation here to make it clear what this package is for?
There was a problem hiding this comment.
Do you mean we should provide some usecases?
My usecase is to allow buildkitd to send caches to buildctl via the content API over BuildKit session API, but I'm not sure I should mention my usecase here.
The package should be useful for 3rd party Go projects. Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
expose-cs-grpc
branch
from
afc96a6 to
7781025
Compare
|
ping @stevvooe |
|
Why are we moving this? The only thing left in the service package is a module registration, which doesn't make a lot of sense. Can we move the registration elsewhere, if that is the problem? |
It will break existing package consumers such as https://github.com/containerd/cri/blob/master/cmd/containerd/containerd.go then, although probably acceptable cc @Random-Liu |
|
Can we move this forward? |
|
Why not just export |
|
These are core services to containerd. containerd is the no. 1 consumer and user of the internal packages. Others can adapt, we shouldn't have to splitup our codebase or compromise on design because something can be used by 3rd parties. containerd comes first when it comes to packages in this repo. The registration is not that big of a deal and does not break anyone else. |
Closes containerd#2441 Signed-off-by: Michael Crosby <[email protected]>
5 participants
The package should be useful for 3rd party Go projects.
Signed-off-by: Akihiro Suda [email protected]
@dmcgowan @tonistiigi