Remove Go version check in travis #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
containerd now only supports Go 1.10+, and travis is not configured to run on older versions, so this check became redundant. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
Jul 5, 2018
| @@ -60,7 +60,7 @@ script: | |||
| - script/validate/vendor | |||
| - go build -i . | |||
| - make check | |||
| - if [[ "$GOOS" = "linux" && "$TRAVIS_GO_VERSION" != "1.9"* ]]; then make check-protos check-api-descriptors; fi | |||
| - if [ "$GOOS" = "linux" ]; then make check-protos check-api-descriptors; fi | |||
There was a problem hiding this comment.
Does travis run on non-Linux at all? If so, we could remove all the if [ "$GOOS" = "linux" ]; checks
Codecov Report
@@ Coverage Diff @@
## master #2437 +/- ##
======================================
Coverage 45% 45%
======================================
Files 92 92
Lines 9412 9412
======================================
Hits 4236 4236
Misses 4493 4493
Partials 683 683
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Jul 5, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containerd now only supports Go 1.10+, and travis is not configured to run on older versions, so this check became redundant.