Introduce plugins/list subcommand#2431
Merged
mlaventure merged 1 commit intocontainerd:masterfrom Jul 2, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2431 +/- ##
======================================
Coverage 45% 45%
======================================
Files 92 92
Lines 9412 9412
======================================
Hits 4236 4236
Misses 4493 4493
Partials 683 683
Continue to review full report at Codecov.
|
Member
|
LGTM |
mlaventure
approved these changes
Jun 29, 2018
cpuguy83
reviewed
Jun 29, 2018
Member
There was a problem hiding this comment.
Alias with ls like other list commands?
Member
There was a problem hiding this comment.
Thought of that just as I clicked Approve :-} I think that's a good suggestion--can we get that small change and then we can merge?
Contributor
Author
There was a problem hiding this comment.
Sure, commit updated
`Ctr` interface follows the pattern `ctr <command> <subcommand>` except for the `plugins` command which does not have subcommands. This feels unnatural to certain users and they would expect that they can list containerd plugins via `ctr plugins list`. This commit implements their expectation so that `plugins` becomes a command "group" and its `list` subcommand actually lists the plugins. Signed-off-by: Danail Branekov <[email protected]>
danail-branekov
force-pushed
the
plugins-list-subcommand
branch
from
edfd24a to
3cf3881
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ctrinterface follows the patternctr <command> <subcommand>exceptfor the
pluginscommand which does not have subcommands. This feelsunnatural to certain users and they would expect that they can list
containerd plugins via
ctr plugins list.This commit implements their expectation so that
pluginsbecomes acommand "group" and its
listsubcommand actually lists the plugins.Signed-off-by: Danail Branekov [email protected]