Skip to content

Document how to use systemd-run#2424

Merged
stevvooe merged 1 commit intocontainerd:masterfrom
kinvolk:alban/systemd-run
Jul 17, 2018
Merged

Document how to use systemd-run#2424
stevvooe merged 1 commit intocontainerd:masterfrom
kinvolk:alban/systemd-run

Conversation

@alban
Copy link
Copy Markdown
Contributor

@alban alban commented Jun 27, 2018

It is also useful when testing local changes, I just run:

sudo systemd-run -p Delegate=yes -p KillMode=process bin/containerd

Signed-off-by: Alban Crequy [email protected]

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 27, 2018

Codecov Report

Merging #2424 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2424   +/-   ##
======================================
  Coverage      45%     45%           
======================================
  Files          92      92           
  Lines        9412    9412           
======================================
  Hits         4236    4236           
  Misses       4493    4493           
  Partials      683     683
Flag Coverage Δ
#linux 49.23% <ø> (ø) ⬆️
#windows 41.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca20431...6ef65b7. Read the comment docs.

Comment thread docs/ops.md Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe say similar instead of equivalent because we are missing the limits on fds and such right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Updating.

It is also useful when testing local changes, I just run:

sudo systemd-run -p Delegate=yes -p KillMode=process bin/containerd

Signed-off-by: Alban Crequy <[email protected]>
@alban alban force-pushed the alban/systemd-run branch from ee68d1b to 6ef65b7 Compare June 27, 2018 14:59
@crosbymichael
Copy link
Copy Markdown
Member

LGTM

1 similar comment
@stevvooe
Copy link
Copy Markdown
Member

LGTM

@stevvooe stevvooe merged commit 9ca2381 into containerd:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants