Add cio.Load for loading io set#2422
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jun 27, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2422 +/- ##
=========================================
- Coverage 45.03% 45% -0.03%
=========================================
Files 92 92
Lines 9407 9412 +5
=========================================
Hits 4236 4236
- Misses 4488 4493 +5
Partials 683 683
Continue to review full report at Codecov.
|
estesp
approved these changes
Jun 26, 2018
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM; minor nit with comment that needs slight wording fix
Member
There was a problem hiding this comment.
minor nit: the "as to deleted" part of this comment may be missing a word/or needs a slight reword for clarity?
This adds a `Load` Opt for cio to load a tasks io/fifos without attaching or starting the copy routines. It adds the load method in `ctr` by default so that fifos or other IO are removed from disk on delete methods inbetween command runs. It is not the default for all task loads for backwards compat. and a user may want to keep io around to reuse or if log files are used. Fixes containerd#2421 Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
ctr-delete
branch
from
b87f088 to
fdceb13
Compare
mlaventure
approved these changes
Jun 26, 2018
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
LoadOpt for cio to load a tasks io/fifos withoutattaching or starting the copy routines.
It adds the load method in
ctrby default so that fifos or other IOare removed from disk on delete methods inbetween command runs. It is
not the default for all task loads for backwards compat. and a user may
want to keep io around to reuse or if log files are used.
Fixes #2421
Signed-off-by: Michael Crosby [email protected]