Codecov Report

Merging #2418 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2418   +/-   ##
=======================================
  Coverage   45.03%   45.03%           
=======================================
  Files          92       92           
  Lines        9407     9407           
=======================================
  Hits         4236     4236           
  Misses       4488     4488           
  Partials      683      683

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f15c3be...e239f65. Read the comment docs.

LGTM

I am confused how to use this with the ctr containers create CLI tool. Could you give an example showing how to use the ctr CLI flags to specify the config.json and the rootfs? The doc says:

NAME:
   ctr containers create - create container

USAGE:
   ctr containers create [command options] [flags] Image|RootFS CONTAINER

But when I give a RootFS in the command line, it seems to be interpreted as an image and I get an error like ctr: image "/path/to/rootfs": not found.

@alban from the original issue report, you need the --rootfs flag to force parsing the "image reference" as a root filesystem path instead of an image reference for both ctr containers create or ctr run:

$ ctr run --rm --gpus 0 --rootfs ~/runc/ubuntu test /bin/bash

ping @alban were you able to get this working?

@estesp @dmcgowan Thanks! I got it working :)

For the record, here are the notes of my test:

	"root": {
		"path": "."
	},
        "process": {
                "args": [
                        "/runtimetest",

$ ctr -n oci-tests containers create --config /tmp/ocitest673856730/config.json --rootfs /tmp/ocitest673856730 39742f98-2908-47e1-8f3f-7da79acaf5c2