Skip to content

fix schema1 fetchBlob()#2390

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
AkihiroSuda:fix-schema1
Jun 7, 2018
Merged

fix schema1 fetchBlob()#2390
dmcgowan merged 1 commit intocontainerd:masterfrom
AkihiroSuda:fix-schema1

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

Fix #2389

Signed-off-by: Akihiro Suda <[email protected]>
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2390 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2390   +/-   ##
=======================================
  Coverage   44.99%   44.99%           
=======================================
  Files          92       92           
  Lines        9398     9398           
=======================================
  Hits         4229     4229           
  Misses       4486     4486           
  Partials      683      683
Flag Coverage Δ
#linux 49.23% <ø> (ø) ⬆️
#windows 41.26% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d4910...703c25e. Read the comment docs.

@ehazlett
Copy link
Copy Markdown
Member

ehazlett commented Jun 7, 2018

LGTM

@estesp
Copy link
Copy Markdown
Member

estesp commented Jun 7, 2018

what's the relationship with #2263? They both seem to be changing similar code in the schema1 converter

@AkihiroSuda
Copy link
Copy Markdown
Member Author

This PR is unrelated to compression.
This PR just avoids -1 size.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Jun 7, 2018

LGTM

@dmcgowan dmcgowan merged commit 63522d9 into containerd:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants