Skip to content

Move runtime/linux/shim -> runtime/shim#2387

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
ehazlett:runtime-shim
Jun 6, 2018
Merged

Move runtime/linux/shim -> runtime/shim#2387
dmcgowan merged 1 commit intocontainerd:masterfrom
ehazlett:runtime-shim

Conversation

@ehazlett
Copy link
Copy Markdown
Member

@ehazlett ehazlett commented Jun 6, 2018

There is no code change here (besides imports); just moving the package runtime/linux/shim to runtime/shim. This is continuing on #2352. It moves the shim from the linux specific package to allow for easier future shim integrations.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2387 into master will decrease coverage by 4.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2387      +/-   ##
==========================================
- Coverage   49.23%   44.99%   -4.24%     
==========================================
  Files          84       92       +8     
  Lines        7462     9398    +1936     
==========================================
+ Hits         3674     4229     +555     
- Misses       3108     4486    +1378     
- Partials      680      683       +3
Flag Coverage Δ
#linux 49.23% <ø> (ø) ⬆️
#windows 41.26% <ø> (?)
Impacted Files Coverage Δ
oci/spec.go 40% <0%> (-10%) ⬇️
snapshots/native/native.go 43.89% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/compression/compression.go 43.93% <0%> (-8.9%) ⬇️
content/local/writer.go 52.63% <0%> (-7.37%) ⬇️
archive/tar.go 43.05% <0%> (-6.95%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
content/local/store.go 51.56% <0%> (-4.29%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437e90a...821c8ea. Read the comment docs.

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 00d4910 into containerd:master Jun 6, 2018
@ehazlett ehazlett deleted the runtime-shim branch June 7, 2018 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants