Skip to content

docker/pusher: handle location string containing path and query#2386

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
northtyphoon:bindu/acr-push-location
Jun 5, 2018
Merged

docker/pusher: handle location string containing path and query#2386
crosbymichael merged 1 commit intocontainerd:masterfrom
northtyphoon:bindu/acr-push-location

Conversation

@northtyphoon
Copy link
Copy Markdown
Contributor

Fix #2385

Signed-off-by: Bin Du [email protected]

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 5, 2018

Codecov Report

Merging #2386 into master will decrease coverage by 8.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2386      +/-   ##
==========================================
- Coverage   49.28%   41.26%   -8.03%     
==========================================
  Files          84       66      -18     
  Lines        7455     7850     +395     
==========================================
- Hits         3674     3239     -435     
- Misses       3101     4103    +1002     
+ Partials      680      508     -172
Flag Coverage Δ
#linux ?
#windows 41.26% <0%> (?)
Impacted Files Coverage Δ
remotes/docker/pusher.go 0% <0%> (ø) ⬆️
snapshots/native/native.go 1.8% <0%> (-52.08%) ⬇️
oci/spec.go 0% <0%> (-50%) ⬇️
metadata/snapshot.go 21.53% <0%> (-33.23%) ⬇️
archive/tar.go 16.85% <0%> (-33.15%) ⬇️
archive/compression/compression.go 43.93% <0%> (-8.9%) ⬇️
content/local/writer.go 51.57% <0%> (-8.43%) ⬇️
oci/spec_opts.go 58.46% <0%> (-7.58%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081b2d6...9b865d8. Read the comment docs.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Jun 5, 2018

LGTM

1 similar comment
@crosbymichael
Copy link
Copy Markdown
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants