Skip to content

Bump console for windows tty handling#2384

Merged
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:bump-console
Jun 5, 2018
Merged

Bump console for windows tty handling#2384
estesp merged 1 commit intocontainerd:masterfrom
crosbymichael:bump-console

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

ref: containerd/console#25

Signed-off-by: Michael Crosby [email protected]

@crosbymichael
Copy link
Copy Markdown
Member Author

cc @mat007

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 5, 2018

Codecov Report

Merging #2384 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2384   +/-   ##
=======================================
  Coverage   45.03%   45.03%           
=======================================
  Files          92       92           
  Lines        9390     9390           
=======================================
  Hits         4229     4229           
  Misses       4478     4478           
  Partials      683      683
Flag Coverage Δ
#linux 49.28% <ø> (ø) ⬆️
#windows 41.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d7fd3f...0cfca1e. Read the comment docs.

Copy link
Copy Markdown

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 081b2d6 into containerd:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants