Fix creation of DirectIO overwriting fifo config#2379
Merged
estesp merged 1 commit intocontainerd:masterfrom Jun 2, 2018
Merged
Fix creation of DirectIO overwriting fifo config#2379estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
Creating a direct IO should not overwrite the fifo configuration. The fifo configuration can be updated before creating the direct io if needed. This fixes an expected change in behavior for clients who were calling NewDirectIO previously with terminal configured on the fifo. Signed-off-by: Derek McGowan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2379 +/- ##
==========================================
+ Coverage 45.03% 45.06% +0.02%
==========================================
Files 92 92
Lines 9390 9385 -5
==========================================
Hits 4229 4229
+ Misses 4478 4473 -5
Partials 683 683
Continue to review full report at Codecov.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a direct IO should not overwrite the fifo configuration. The fifo configuration can be updated
before creating the direct io if needed. This fixes an unexpected change in behavior for clients who were calling
NewDirectIOpreviously with terminal configured on the fifo.This reverts the non-test code change from #2310 with an alternate solution in the test which just configures the fifos with the terminal setting.