Fix size validation bug with some registries#2364
Merged
estesp merged 1 commit intocontainerd:masterfrom May 29, 2018
Merged
Conversation
Ensures that the client can handle cases where the registry ignores content length. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2364 +/- ##
==========================================
+ Coverage 44.99% 45.11% +0.11%
==========================================
Files 92 92
Lines 9336 9358 +22
==========================================
+ Hits 4201 4222 +21
Misses 4457 4457
- Partials 678 679 +1
Continue to review full report at Codecov.
|
Member
|
Is 1.0.x affected? |
AkihiroSuda
approved these changes
May 28, 2018
Member
Author
|
@AkihiroSuda it is client side, so the daemon is not affected, but the clients are. I can backport to 1.0.x for those vendoring the client from 1.0. My main concern is 1.1 since the cri plugin does use the client code for pulling. I'll open a PR to both though. |
This was referenced May 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that the client can handle cases where the registry ignores content range.
Some registries ignore the content range and in some cases supports inconsistently. For example the Docker Hub appears to use Cloudflare and Cloudfront for serving content, cloudflare will ignore the content range while cloudfront uses it. This has lead to many cases of the mismatched layer size error on pull but without a consistent reproduction.
Closes #2306