Implement WithNoNewKeyring#2361
Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom May 29, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2361 +/- ##
=======================================
Coverage 44.99% 44.99%
=======================================
Files 92 92
Lines 9336 9336
=======================================
Hits 4201 4201
Misses 4457 4457
Partials 678 678
Continue to review full report at Codecov.
|
Member
|
Can you squash into 1 commit now that it's passing? |
AkihiroSuda
reviewed
May 27, 2018
yulianedyalkova
force-pushed
the
no-new-keyring
branch
3 times, most recently
from
f43db7c to
2fc9a43
Compare
It does not override existing CreateOptions but assumes that the TaskInfo's options are of type CreateOptions. Signed-off-by: Oliver Stenbom <[email protected]>
yulianedyalkova
force-pushed
the
no-new-keyring
branch
from
2fc9a43 to
7132ca2
Compare
Member
|
LGTM |
AkihiroSuda
approved these changes
May 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithNoNewKeyring causes tasks not to be created with a new keyring for secret storage.
There is an upper limit on the number of keyrings in a linux system, so passing this flag allows more containers to be created than the keyring limit.
Implements #2360
Signed-off-by: Oliver Stenbom [email protected]