Skip to content

Add Evan Hazlett as a reviewer#2357

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
dmcgowan:add-evan-reviewer
May 24, 2018
Merged

Add Evan Hazlett as a reviewer#2357
crosbymichael merged 1 commit intocontainerd:masterfrom
dmcgowan:add-evan-reviewer

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

Evan is an active contributor and been contributing for awhile now. He has been gaining expertise in the runtime code and has been helping review PRs. I think we should add him as a reviewer.

Signed-off-by: Derek McGowan <[email protected]>
@Random-Liu
Copy link
Copy Markdown
Member

LGTM

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2357 into master will decrease coverage by 4.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2357     +/-   ##
=========================================
- Coverage   49.29%   44.99%   -4.3%     
=========================================
  Files          84       92      +8     
  Lines        7421     9336   +1915     
=========================================
+ Hits         3658     4201    +543     
- Misses       3088     4457   +1369     
- Partials      675      678      +3
Flag Coverage Δ
#linux 49.29% <ø> (ø) ⬆️
#windows 41.25% <ø> (?)
Impacted Files Coverage Δ
oci/spec.go 40% <0%> (-10%) ⬇️
snapshots/native/native.go 43.89% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/compression/compression.go 43.93% <0%> (-8.9%) ⬇️
remotes/docker/fetcher.go 41.42% <0%> (-7.6%) ⬇️
content/local/writer.go 52.63% <0%> (-7.37%) ⬇️
archive/tar.go 43.05% <0%> (-6.95%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1435e6...a4e4af1. Read the comment docs.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 195aec2 into containerd:master May 24, 2018
@dmcgowan dmcgowan deleted the add-evan-reviewer branch June 5, 2018 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants