Skip to content

Bump continuity to fix copy files > 2^32 bytes#2354

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
cpuguy83:bump_continuity
May 24, 2018
Merged

Bump continuity to fix copy files > 2^32 bytes#2354
crosbymichael merged 1 commit intocontainerd:masterfrom
cpuguy83:bump_continuity

Conversation

@cpuguy83
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 commented May 23, 2018

@dmcgowan
Copy link
Copy Markdown
Member

Looks like you need to go get -u github.com/lk4d4/vndr locally

@cpuguy83
Copy link
Copy Markdown
Member Author

Yeah, I updated, no changes when re-running.

@cpuguy83
Copy link
Copy Markdown
Member Author

Ok, just dropped and re-ran vdnr it seems to be fine now.

@dmcgowan
Copy link
Copy Markdown
Member

This caused some of the archive tests to fail, I am investigating

@dmcgowan
Copy link
Copy Markdown
Member

Looks like this will need a fix in continuity, I am going to open up an issue there. The problem is readers are being created outside of the closure but the closure is called multiple times.

@dmcgowan
Copy link
Copy Markdown
Member

Opened containerd/continuity#117 to fix

@cpuguy83
Copy link
Copy Markdown
Member Author

--- FAIL: TestImagePullSomePlatforms (1.95s)
	client_test.go:297: expected a different number of pulled manifests

All tests pass for me locally.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2354 into master will decrease coverage by 4.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2354     +/-   ##
=========================================
- Coverage   49.29%   44.99%   -4.3%     
=========================================
  Files          84       92      +8     
  Lines        7421     9336   +1915     
=========================================
+ Hits         3658     4201    +543     
- Misses       3088     4457   +1369     
- Partials      675      678      +3
Flag Coverage Δ
#linux 49.29% <ø> (ø) ⬆️
#windows 41.25% <ø> (?)
Impacted Files Coverage Δ
oci/spec.go 40% <0%> (-10%) ⬇️
snapshots/native/native.go 43.89% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/compression/compression.go 43.93% <0%> (-8.9%) ⬇️
remotes/docker/fetcher.go 41.42% <0%> (-7.6%) ⬇️
content/local/writer.go 52.63% <0%> (-7.37%) ⬇️
archive/tar.go 43.05% <0%> (-6.95%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
metadata/buckets.go 56.33% <0%> (-4.6%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1435e6...7e5a91f. Read the comment docs.

@dmcgowan
Copy link
Copy Markdown
Member

expected a different number of pulled manifests

This is a result of the tests using the hub, sometimes during image updates the tag gets updated prematurely to a manifest list which does not have all the architectures.

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 0540612 into containerd:master May 24, 2018
@cpuguy83 cpuguy83 deleted the bump_continuity branch May 24, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants