Move top level packages into pkg or specific sub pkgs#2351
Move top level packages into pkg or specific sub pkgs#2351estesp merged 6 commits intocontainerd:masterfrom
Conversation
Signed-off-by: Michael Crosby <[email protected]>
Signed-off-by: Michael Crosby <[email protected]>
Signed-off-by: Michael Crosby <[email protected]>
Signed-off-by: Michael Crosby <[email protected]>
Signed-off-by: Michael Crosby <[email protected]>
Signed-off-by: Michael Crosby <[email protected]>
|
|
||
| "github.com/containerd/containerd/archive/compression" | ||
| "github.com/containerd/containerd/testutil" | ||
| "github.com/containerd/containerd/pkg/testutil" |
There was a problem hiding this comment.
if this is just for testing, have you considered putting it in internal?
There was a problem hiding this comment.
I think most of the packages under pkg could be considered internal, but not sure that package naming is worth using.
There was a problem hiding this comment.
Yeah, I know we moved some packages to internal in the Moby to more clearly indicate we don't provide any compatibility guarantee (pkg feels more as "here, you can use this in your own project")
There was a problem hiding this comment.
we document what is supported and what is not. things we expect ppl to depend on a broken out into separate repos. I don't think its worth it at this point
Codecov Report
@@ Coverage Diff @@
## master #2351 +/- ##
=========================================
- Coverage 49.29% 44.99% -4.3%
=========================================
Files 84 92 +8
Lines 7421 9336 +1915
=========================================
+ Hits 3658 4201 +543
- Misses 3088 4457 +1369
- Partials 675 678 +3
Continue to review full report at Codecov.
|
5 participants
No description provided.