Skip to content

Return Markdown files to /docs directory#2344

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
lucperkins:lperkins/revert-markdown-file-paths
May 16, 2018
Merged

Return Markdown files to /docs directory#2344
crosbymichael merged 1 commit intocontainerd:masterfrom
lucperkins:lperkins/revert-markdown-file-paths

Conversation

@lucperkins
Copy link
Copy Markdown
Contributor

In PR #2342 I moved some existing Markdown to a Hugo-specific directory without realizing that it needs to stay in the /docs directory. This PR returns those files to their original home.

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 16, 2018

Codecov Report

Merging #2344 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2344   +/-   ##
=======================================
  Coverage   44.99%   44.99%           
=======================================
  Files          92       92           
  Lines        9336     9336           
=======================================
  Hits         4201     4201           
  Misses       4457     4457           
  Partials      678      678
Flag Coverage Δ
#linux 49.29% <ø> (ø) ⬆️
#windows 41.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2e115...e5e6353. Read the comment docs.

@estesp
Copy link
Copy Markdown
Member

estesp commented May 16, 2018

Looks like the right set of files; we also probably want to remove the small markdown table that is used by Hugo but gets rendered in GH (title, draft status)

@lucperkins
Copy link
Copy Markdown
Contributor Author

@estesp Done

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 3f0fe90 into containerd:master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants