@williammartin can you take a look and test this solution?

Codecov Report

Merging #2336 into master will increase coverage by 4.29%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #2336      +/-   ##
==========================================
+ Coverage   44.99%   49.29%   +4.29%     
==========================================
  Files          92       84       -8     
  Lines        9336     7421    -1915     
==========================================
- Hits         4201     3658     -543     
+ Misses       4457     3088    -1369     
+ Partials      678      675       -3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80272bb...62e22a9. Read the comment docs.

Have asked the team to take a look, thanks.

Any word on this fixing the issues you are seeing?

@containerd/containerd-maintainers you can review this as well

LGTM

Thanks for chasing and sorry for the delay.

The place where we get this error is actually on

I did try to play the same trick by adding:

type Spec = specs.Spec

and changing the function signature to:

func WithSpec(s *Spec, opts ...oci.SpecOpts) NewContainerOpts

But it didn't resolve anything (not sure if the type is leaking somewhere else):

../../rundmc/runcontainerd/nerd/nerd.go:27:85: cannot use spec (type *"github.com/opencontainers/runtime-spec/specs-go".Spec) as type *"github.com/containerd/containerd/vendor/github.com/opencontainers/runtime-spec/specs-go".Spec in argument to containerd.WithSpec

Can you point me to where you found that type alias would resolve vendor conflicts? I can’t seem to find anything about it and in a simplified case (https://github.com/williammartin/alias) type aliasing doesn’t seem to resolve conflicts (but it’s totally possible I’m doing something stupid). Maybe you can fill me in on what I’m missing.

Finally, because of this, and a bunch of other reasons that have built up over time, we are in the process of switching all our vendoring to a more suitable scheme (dep or vndr) which as discussed previously, should flatten the vendor hierarchy and avoid this whole thing altogether. As such, I suspect we won't really need anything from containerd. Can update you as we progress with that, since it's halfway through in a weird state right now. Thanks.

@williammartin you actually have to change your implementations also to use oci.Spec instead of specs.Spec

@williammartin i also pushed an update changing the container opts to oci.Spec.

I believe if you change your calling code from having specs.Spec to oci.Spec it will resolve the issues you are seeing like it did for me. I was having the same issues.

@crosbymichael Ah you're right, when I did that in my test example it seemed to work. I can give this a go in Garden when I have a spare moment (infrequently I'm afraid!).

LGTM