Add missing return statement on pull unpack#2332
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom May 8, 2018
Merged
Add missing return statement on pull unpack#2332crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Derek McGowan <[email protected]>
Member
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #2332 +/- ##
=========================================
- Coverage 49.28% 44.98% -4.3%
=========================================
Files 84 92 +8
Lines 7424 9340 +1916
=========================================
+ Hits 3659 4202 +543
- Misses 3089 4459 +1370
- Partials 676 679 +3
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
May 8, 2018
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error return is missing. This went out in 1.1 but currently the cri plugin and ctr tool do not use the unpack option. Marking this for backport but not critical.