Skip to content

Move import/export code to separate client file#2328

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:client-clean
May 4, 2018
Merged

Move import/export code to separate client file#2328
dmcgowan merged 1 commit intocontainerd:masterfrom
crosbymichael:client-clean

Conversation

@crosbymichael
Copy link
Copy Markdown
Member

Signed-off-by: Michael Crosby [email protected]

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2328 into master will decrease coverage by 4.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2328      +/-   ##
==========================================
- Coverage   49.29%   44.98%   -4.31%     
==========================================
  Files          84       92       +8     
  Lines        7415     9331    +1916     
==========================================
+ Hits         3655     4198     +543     
- Misses       3086     4456    +1370     
- Partials      674      677       +3
Flag Coverage Δ
#linux 49.29% <ø> (ø) ⬆️
#windows 41.24% <ø> (?)
Impacted Files Coverage Δ
oci/spec.go 40% <0%> (-10%) ⬇️
snapshots/native/native.go 43.89% <0%> (-10%) ⬇️
metadata/snapshot.go 45.8% <0%> (-8.96%) ⬇️
archive/compression/compression.go 43.93% <0%> (-8.9%) ⬇️
remotes/docker/fetcher.go 41.42% <0%> (-7.6%) ⬇️
content/local/writer.go 52.63% <0%> (-7.37%) ⬇️
archive/tar.go 43.05% <0%> (-6.95%) ⬇️
metadata/containers.go 47.97% <0%> (-6.62%) ⬇️
metadata/buckets.go 54.66% <0%> (-5.04%) ⬇️
metadata/images.go 58.46% <0%> (-4.7%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22c827...8ee52bf. Read the comment docs.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented May 4, 2018

LGTM

@dmcgowan dmcgowan merged commit e017143 into containerd:master May 4, 2018
@crosbymichael crosbymichael deleted the client-clean branch May 7, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants