Don't fail on setting -ve oom score when rootless#2326
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom May 4, 2018
Merged
Don't fail on setting -ve oom score when rootless#2326dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan merged 1 commit intocontainerd:masterfrom
Conversation
Callisto13
force-pushed
the
pr-oom-score
branch
2 times, most recently
from
764e295 to
ae4a0c8
Compare
This allows non-privileged users to use containerd. If a non root user tried to set a negative oom score adjustment, it will fail. Containerd should not fail if running rootless. This is part of a larger track of work integrating containerd into Cloudfoundry's garden with support for rootless. [#156343443] Signed-off-by: Danail Branekov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2326 +/- ##
==========================================
- Coverage 45.43% 44.98% -0.45%
==========================================
Files 83 92 +9
Lines 9214 9331 +117
==========================================
+ Hits 4186 4198 +12
- Misses 4352 4456 +104
- Partials 676 677 +1
Continue to review full report at Codecov.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows non-privileged users to use containerd.
If a non root user tried to set a negative oom score adjustment on a proc,
it will fail. Containerd should not fail if running rootless.
This is part of a larger track of work integrating containerd
into Cloudfoundry's garden with support for rootless.
Here is a link to our track of containerd/rootless work: https://www.pivotaltracker.com/n/projects/1158420/search?q=label%3A%22containerd%22
[#156343443]
Signed-off-by: Claudia Beresford [email protected]