Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to latest go-digest. #2319

Merged
merged 2 commits into from
May 1, 2018
Merged

Conversation

ijc
Copy link
Contributor

@ijc ijc commented Apr 30, 2018

This renames the license file (so automated tooling can find it, which I care
about) and also pulls in some documentation and comment changes, plus some
functional changes:

PR#33 -- future-proof the algorithm field.
PR#34 -- disallow upper case in hex portion.

No changes appear to be required to containerd code.

Signed-off-by: Ian Campbell [email protected]
(same as moby/buildkit#356, seemed like it made sense to do it here too)

This renames the license file (so automated tooling can find it, which I care
about) and also pulls in some documentation and comment changes, plus some
functional changes:

PR#33 -- future-proof the algorithm field.
PR#34 -- disallow upper case in hex portion.

No changes appear to be required to containerd code.

Signed-off-by: Ian Campbell <[email protected]>
@dmcgowan
Copy link
Member

Hmm, unlucky change picked up LK4D4/vndr@1fc68ee ?

@ijc
Copy link
Contributor Author

ijc commented Apr 30, 2018

Yea, sucks to be me :-/

I'll update my vndr and add that update here.

This seems to pickup a bunch of *.c files and some other changes which follow
from having included some new packages because of that.

Signed-off-by: Ian Campbell <[email protected]>
@dmcgowan
Copy link
Member

LGTM

@codecov-io
Copy link

Codecov Report

Merging #2319 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2319   +/-   ##
=======================================
  Coverage   45.41%   45.41%           
=======================================
  Files          83       83           
  Lines        9210     9210           
=======================================
  Hits         4183     4183           
  Misses       4351     4351           
  Partials      676      676
Flag Coverage Δ
#linux 49.9% <ø> (ø) ⬆️
#windows 41.24% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4219f7b...623407a. Read the comment docs.

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit cfba048 into containerd:master May 1, 2018
@ijc ijc deleted the update-go-digest branch May 1, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants