Add restart manager to containerd by crosbymichael · Pull Request #2318 · containerd/containerd

crosbymichael · 2018-04-30T21:06:35Z

This PR adds a restart manager that allows containerd to keep tasks running for containers. It is built decoupled so that clients create and manage containers like always but and optionally set a state with the restart manager.

container, err := client.NewContainer(ctx, id , restart.WithStatus(containerd.Running))
// update status
container.Update(ctx, restart.WithUpdatedStatus(containerd.Stopped))
// clear management 
container.Update(ctx, restart.WithNoRestart)

dmcgowan · 2018-04-30T21:25:46Z

I have a few questions about the restart info life span that I couldn't answer on my first pass through the code.

What is responsible for removing the restart after a container is deleted?
Can a restart be created on a container id that does not exist?
When a container is deleted, should the restart be deleted at the same time?

crosbymichael · 2018-04-30T21:28:43Z

The manager will remove it if the container is not found. However, currently there is a race that you could create a new container with the same id and it will be restarted from an existing container. Working on a solution for that.
no
That would be best but i'm not sure how to do that.

dmcgowan · 2018-04-30T21:34:42Z

That would be best but i'm not sure how to do that.

I was wondering if we could move the restart bucket under the container bucket, so it just gets removed with the container. The restart manager would then just need to reconcile its own state and not update the database.

AkihiroSuda · 2018-05-01T12:12:33Z

Can we use event API?

AkihiroSuda · 2018-05-01T12:17:01Z

Can we optionally support exponential backoff?
Can we optionally support specifying max retry count?

crosbymichael · 2018-05-01T15:09:21Z

@dmcgowan I could put this information on container's labels and do it that way. Then we have no need for a new grpc service. What do you think?

API would look something like this.

container, err := client.NewContainer(ctx, id , restart.WithStatus(containerd.Running))
// update status
container.Update(ctx, restart.WithUpdatedStatus(containerd.Stopped))
// clear management 
container.Update(ctx, restart.WithNoRestart)

crosbymichael · 2018-05-01T16:17:54Z

Updated per discussion. I'll squash when we are happy with design

codecov-io · 2018-05-01T17:33:45Z

Codecov Report

Merging #2318 into master will increase coverage by 0.43%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2318      +/-   ##
==========================================
+ Coverage   44.98%   45.42%   +0.43%     
==========================================
  Files          92       83       -9     
  Lines        9340     9206     -134     
==========================================
- Hits         4202     4182      -20     
+ Misses       4459     4349     -110     
+ Partials      679      675       -4

Flag	Coverage Δ
#linux	`49.91% <100%> (+0.62%)`	⬆️
#windows	`41.25% <100%> (ø)`	⬆️

Impacted Files	Coverage Δ
metadata/buckets.go	`56.33% <100%> (+1.67%)`	⬆️
mount/temp.go	`0% <0%> (-14.29%)`	⬇️
sys/proc.go
sys/filesys_unix.go
sys/env.go
sys/epoll.go
sys/socket_unix.go
sys/reaper.go
sys/fds.go
sys/stat_unix.go
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63768e...2b565da. Read the comment docs.

dmcgowan · 2018-05-01T17:44:55Z

Would the custom stop signal mean, call task.Wait, issue task.Kill with custom signal, wait and timeout, call task.Kill with sig kill?

dmcgowan · 2018-05-01T17:49:30Z

Use of this type is weird, we have a TaskMonitorPlugin, should we just have a MonitorPlugin or more generic plugin type? This should be typed for ctr plugins though.

a task monitor won't work as is because it will cause a recursive error. I'll make a new type, i just found that one and did what I needed

dmcgowan · 2018-05-01T18:02:42Z

This can be removed now

dmcgowan · 2018-05-01T18:04:06Z

I believe there is a config generator somewhere that needs to have a marshal for this too

dmcgowan · 2018-05-01T21:52:47Z

Can we get rid of this debug line? A debug line after desired state isn't matched is probably more useful.

Random-Liu · 2018-05-02T08:09:55Z

What is the use case? Are we going to use this in Docker or Linuxkit?

Can we add build tag, and make the plugin opt-in or at least opt-out in compilation, e.g. builtins_restart.go? I don't think we'll ever use it in Kubernetes given the current abstraction level of CRI.

Kubernetes won't use it, if Docker is not going to use it anytime soon, I think we should make this opt-in.

crosbymichael · 2018-05-02T13:40:42Z

@Random-Liu you can disable plugins via the config, I don't think this functionality should be hidden behind a buildtag and there isn't any overhead for something like this if you are not using it to warrant a build tag.

The usecase is for system level containers, it will allow remote snapshotters, runtimes, and such to be kept running without any external deps on a system. Its not built for the kube or docker restart policies, just a simple internal function to keep low level system containers running, maybe something like kubelet in a container ;)

Random-Liu · 2018-05-02T17:51:27Z

you can disable plugins via the config, I don't think this functionality should be hidden behind a buildtag and there isn't any overhead for something like this if you are not using it to warrant a build tag.

@crosbymichael I forgot that I added that. :P

The usecase is for system level containers, it will allow remote snapshotters, runtimes, and such to be kept running without any external deps on a system.

Sounds like a use case in Linuxkit.

Its not built for the kube or docker restart policies, just a simple internal function to keep low level system containers running, maybe something like kubelet in a container

I hope Docker won't use this in the future. The reason is that:

I do think for Kubernetes, we'd prefer disabling it, less unnecessary functionality makes the system more stable.
I guess many users will still be using Docker, just configure Kubelet to talk with containerd. If docker rely on this behavior, we won't be able to disable it.

I'm fine with this particular change, because the feature can be disabled, and the change is small enough to me.

But I hope the scope of containerd won't extend too much over time. :)

crosbymichael · 2018-05-02T17:59:16Z

@Random-Liu i think you are reading it wrong because nothing uses this by default, nothing changes the way things work today and you don't have to change a single line of code in CRI to not use this.

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit bd6920b25b8f25f002cba7e8544e46cae3d085e0:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1248?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit bd6920b25b8f25f002cba7e8544e46cae3d085e0:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1248?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bd6920b25b8f25f002cba7e8544e46cae3d085e0:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1248?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 37db2de25dbb22b928ff2ff2ece42670721f2a13:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1249?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 3240[37db2de25dbb22b928ff2ff2ece42670721f2a13] master rn open "November 2018 development report" [|0 rn: "\r\n![beaver](https://user-images.githubusercontent.com/3338098/49466286-9266e600-"|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37db2de25dbb22b928ff2ff2ece42670721f2a13} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {{linuxkit/linuxkit bd6920b25b8f25f002cba7e8544e46cae3d085e0} ci/circleci} {{linuxkit/linuxkit bd6920b25b8f25f002cba7e8544e46cae3d085e0} ci/datakit/linuxkit-ci} {{linuxkit/linuxkit bd6920b25b8f25f002cba7e8544e46cae3d085e0} dco-signed} {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bd6920b25b8f25f002cba7e8544e46cae3d085e0} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 37db2de25dbb22b928ff2ff2ece42670721f2a13:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 37db2de25dbb22b928ff2ff2ece42670721f2a13:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1249?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37db2de25dbb22b928ff2ff2ece42670721f2a13:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1249?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {{linuxkit/linuxkit 37db2de25dbb22b928ff2ff2ece42670721f2a13} ci/circleci} {{linuxkit/linuxkit 37db2de25dbb22b928ff2ff2ece42670721f2a13} ci/datakit/linuxkit-ci} {{linuxkit/linuxkit 37db2de25dbb22b928ff2ff2ece42670721f2a13} dco-signed} {linuxkit/linuxkit 3240} {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 37db2de25dbb22b928ff2ff2ece42670721f2a13} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit heads/master[9fbf50c3035aa73f057c52f3e348c6dfa38440f9]} {linuxkit/linuxkit 9fbf50c3035aa73f057c52f3e348c6dfa38440f9:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1250?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit 9fbf50c3035aa73f057c52f3e348c6dfa38440f9} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {{linuxkit/linuxkit ed57c3d1e2c328a0fe6633f2f0b6f7aa561a1774} ci/circleci} {{linuxkit/linuxkit ed57c3d1e2c328a0fe6633f2f0b6f7aa561a1774} ci/datakit/linuxkit-ci} {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit ed57c3d1e2c328a0fe6633f2f0b6f7aa561a1774} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 9fbf50c3035aa73f057c52f3e348c6dfa38440f9:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1250?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 9fbf50c3035aa73f057c52f3e348c6dfa38440f9:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1250?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {{linuxkit/linuxkit 2a1f90fff136c5766140e68ae03aa549d106fb7a} ci/circleci} {{linuxkit/linuxkit 2a1f90fff136c5766140e68ae03aa549d106fb7a} ci/datakit/linuxkit-ci} {{linuxkit/linuxkit 2a1f90fff136c5766140e68ae03aa549d106fb7a} dco-signed} {linuxkit/linuxkit 3239} {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 2a1f90fff136c5766140e68ae03aa549d106fb7a} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit heads/master[953e63ec551fcf124e2e79cd46af1a54262523da]} {linuxkit/linuxkit 953e63ec551fcf124e2e79cd46af1a54262523da:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1251?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit 953e63ec551fcf124e2e79cd46af1a54262523da} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {{linuxkit/linuxkit 9fbf50c3035aa73f057c52f3e348c6dfa38440f9} ci/circleci} {{linuxkit/linuxkit 9fbf50c3035aa73f057c52f3e348c6dfa38440f9} ci/datakit/linuxkit-ci} {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit 9fbf50c3035aa73f057c52f3e348c6dfa38440f9} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 953e63ec551fcf124e2e79cd46af1a54262523da:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1251?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 953e63ec551fcf124e2e79cd46af1a54262523da:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1251?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit a5e65cfeea247623cd35001268eb1191fcb0556d:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1252?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 3242[a5e65cfeea247623cd35001268eb1191fcb0556d] master rn open "Update kernels to 4.19.7/4.14.86/4.9.143" [|0 rn: "![dusky-leaf-monkey](https://user-images.githubusercontent.com/3338098/49620340-"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit a5e65cfeea247623cd35001268eb1191fcb0556d} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit a5e65cfeea247623cd35001268eb1191fcb0556d:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit a5e65cfeea247623cd35001268eb1191fcb0556d:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1252?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@justincormack

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit a5e65cfeea247623cd35001268eb1191fcb0556d:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1252?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3230[1283946ab0c18c7d4be8ed86b8371d8d836f5048] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 2648[bfaa9e7fc599a8b9edba4429ae513f0736411fce] master w9n open "linuxkit bake" [|0 w9n: "When writing a moby yml I do not care about the container version and hashes (on"; 340192010 GordonTheTurtle: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@medic15

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 51db824fb3df5482c4c94e46a4e0d0d509f35249:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1253?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds} {linuxkit/linuxkit 51db824fb3df5482c4c94e46a4e0d0d509f35249:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3168[1d1c8fcee99d58781b90bc646398046d22e286ef] master kkroo open "Use containerd restart manager to monitor services" [|0 kkroo: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 3230[51db824fb3df5482c4c94e46a4e0d0d509f35249] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 51db824fb3df5482c4c94e46a4e0d0d509f35249} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {{linuxkit/linuxkit 1283946ab0c18c7d4be8ed86b8371d8d836f5048} ci/circleci} {{linuxkit/linuxkit 1283946ab0c18c7d4be8ed86b8371d8d836f5048} ci/datakit/linuxkit-ci} {{linuxkit/linuxkit 1283946ab0c18c7d4be8ed86b8371d8d836f5048} dco-signed} {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 1283946ab0c18c7d4be8ed86b8371d8d836f5048} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@medic15

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 51db824fb3df5482c4c94e46a4e0d0d509f35249:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1253?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3168[1d1c8fcee99d58781b90bc646398046d22e286ef] master kkroo open "Use containerd restart manager to monitor services" [|0 kkroo: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 3230[51db824fb3df5482c4c94e46a4e0d0d509f35249] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@medic15

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 51db824fb3df5482c4c94e46a4e0d0d509f35249:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1253?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3168[1d1c8fcee99d58781b90bc646398046d22e286ef] master kkroo open "Use containerd restart manager to monitor services" [|0 kkroo: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 3230[51db824fb3df5482c4c94e46a4e0d0d509f35249] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@medic15

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3168[1d1c8fcee99d58781b90bc646398046d22e286ef] master kkroo open "Use containerd restart manager to monitor services" [|0 kkroo: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 3230[51db824fb3df5482c4c94e46a4e0d0d509f35249] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@medic15

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3168[1d1c8fcee99d58781b90bc646398046d22e286ef] master kkroo open "Use containerd restart manager to monitor services" [|0 kkroo: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 3230[51db824fb3df5482c4c94e46a4e0d0d509f35249] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {{linuxkit/linuxkit a5e65cfeea247623cd35001268eb1191fcb0556d} ci/circleci} {{linuxkit/linuxkit a5e65cfeea247623cd35001268eb1191fcb0556d} ci/datakit/linuxkit-ci} {{linuxkit/linuxkit a5e65cfeea247623cd35001268eb1191fcb0556d} dco-signed} {linuxkit/linuxkit 3242} {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a5e65cfeea247623cd35001268eb1191fcb0556d} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@medic15

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit heads/master[7dab74734583fe4416894ee868749063987bd084]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 7dab74734583fe4416894ee868749063987bd084:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1254?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3168[1d1c8fcee99d58781b90bc646398046d22e286ef] master kkroo open "Use containerd restart manager to monitor services" [|0 kkroo: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 3230[51db824fb3df5482c4c94e46a4e0d0d509f35249] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 7dab74734583fe4416894ee868749063987bd084} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {{linuxkit/linuxkit 953e63ec551fcf124e2e79cd46af1a54262523da} ci/circleci} {{linuxkit/linuxkit 953e63ec551fcf124e2e79cd46af1a54262523da} ci/datakit/linuxkit-ci} {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 953e63ec551fcf124e2e79cd46af1a54262523da} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@medic15

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 7dab74734583fe4416894ee868749063987bd084:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1254?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3168[1d1c8fcee99d58781b90bc646398046d22e286ef] master kkroo open "Use containerd restart manager to monitor services" [|0 kkroo: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 3230[51db824fb3df5482c4c94e46a4e0d0d509f35249] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@medic15

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 7dab74734583fe4416894ee868749063987bd084:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/1254?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3168[1d1c8fcee99d58781b90bc646398046d22e286ef] master kkroo open "Use containerd restart manager to monitor services" [|0 kkroo: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 3230[51db824fb3df5482c4c94e46a4e0d0d509f35249] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@medic15

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit b1e78ab661b61a32daf58996b910c59e4288b7ca:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1255?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests are queued behind your running builds} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit b1e78ab661b61a32daf58996b910c59e4288b7ca:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3168[1d1c8fcee99d58781b90bc646398046d22e286ef] master kkroo open "Use containerd restart manager to monitor services" [|0 kkroo: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 3230[b1e78ab661b61a32daf58996b910c59e4288b7ca] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit b1e78ab661b61a32daf58996b910c59e4288b7ca} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {{linuxkit/linuxkit 51db824fb3df5482c4c94e46a4e0d0d509f35249} ci/circleci} {{linuxkit/linuxkit 51db824fb3df5482c4c94e46a4e0d0d509f35249} ci/datakit/linuxkit-ci} {{linuxkit/linuxkit 51db824fb3df5482c4c94e46a4e0d0d509f35249} dco-signed} {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit 51db824fb3df5482c4c94e46a4e0d0d509f35249} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

@medic15

Updated {linuxkit/linuxkit tags/v0.2[1c552f7a9db7f0660d3c83362d241e54142323ca]} {linuxkit/linuxkit tags/v0.3[37e29b45b3a5015e846f64ab32dffb7a48c32b3a]} {linuxkit/linuxkit tags/v0.4[8d17887e11c7ad25efd7f201b8dfe2b0badc4bee]} {linuxkit/linuxkit b1e78ab661b61a32daf58996b910c59e4288b7ca:ci/circleci[pending] url=https://circleci.com/gh/linuxkit/linuxkit/1255?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=CircleCI is running your tests} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:dco-signed[success] descr=All commits are signed} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/123?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit bfaa9e7fc599a8b9edba4429ae513f0736411fce:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/460?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/754?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/852?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 93da004019fee680fc7cbbc158a90390af407386:ci/circleci[success] url=https://circleci.com/gh/linuxkit/linuxkit/868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link descr=Your tests passed on CircleCI!} {linuxkit/linuxkit 3168[1d1c8fcee99d58781b90bc646398046d22e286ef] master kkroo open "Use containerd restart manager to monitor services" [|0 kkroo: "\nPlease sign your commits following thes"; 416566165 justincormack: "Hi, we can't merge PRs unless they are signed-off-by as per instructions above.\r"; 417360415 ijc: "containerd/containerd#2318 shows it using `container.Upd"; 442205572 kkroo: "Addressing comments regarding race conditions. Regarding the use of this interfa"; 442222157 medic15: "This needs to be configurable for each service. Not all those who wander are lo"; 442319928 kkroo: "> This needs to be configurable for each service. Not all those who wander are l"; 442400886 ijc: "@medic15 and @justincormack are correct, this needs to be configurable per servi"; 442401015 justincormack: "At present a few of the services we run may terminate (eg `rngd` if no rng is su"; 442472675 medic15: "My use case involves populating a Redis in-memory database using data from sever"; 442473416 justincormack: "@medic15 yes that seems a reasonable use case where it should be configurable."; 442621437 kkroo: "@medic15 @justincormack I still don't understand the use case and why such a one"; 442622363 justincormack: "Services are not started until all `onboot` containers have exited."|]} {linuxkit/linuxkit 2479[47574bb9c351241c2833f9257ed2eb6c805ca930] master TheOriginalAlex open "Setup the bond interfaces with proper default routes" [|0 TheOriginalAlex: "We need to add the addresses first and then set the routes, that way if the priv"; 326737114 justincormack: "re \"- How to verify it - Run on a Packet Type 0 server.\" you need to run on type"; 334149593 justincormack: "@TheOriginalAlex hi, have you had a chance to test this on type 2? I have been a"; 344279607 justincormack: "I am working on an updated version of this."; 344383444 TheOriginalAlex: "Sure! Sorry, I haven't responded much. Been busy. Also, I got stuck on gettin"; 345272016 justincormack: "@TheOriginalAlex what problems were you seeing with the default gateway?"; 345429732 TheOriginalAlex: "It just wasn't getting set. If I printed the output of nsenter.RouteList, I cou"; 345674031 justincormack: "Routes seemed to be working for me ok, but I need to rebase against the new meta"|]} {linuxkit/linuxkit 3230[b1e78ab661b61a32daf58996b910c59e4288b7ca] master simar7 open "pkg/bpftrace: Add bpftrace as a core pkg" [|0 simar7: "\nPlease sign your commits following thes"; 340204660 rn: "I don't understand the explanation for this PR (maybe I'm missing some context)."; 340224169 w9n: "added some context to the description. "; 340241991 deitch: "> When writing a moby yml I do not care about the container version and hashes ("; 340268573 w9n: "i basically thought of a not buildable config\r\n```\r\nkernel:\r\n image: linuxkit/k"; 340269095 deitch: "So, is this basically a way of saying, \"for some packages, I want the latest ava"; 340269511 w9n: "yep, but still create the immutable ymls so its reproducable what has been build"; 340269588 deitch: "So rather than the usual moby `.yml`, it kind of is a moby \"template\" `.yml`, th"; 340269816 w9n: "exactly. It would enable other possibilities as well as described above but ther"; 340269924 deitch: "OK, I get it now; want to think it over somewhat. @rn had commented earlier; let"; 340270518 rn: "This would be better done in the `moby` tool as it handles the build YAML files."; 340271020 deitch: "Ah yes, the `.mobytags` and overrides proposals.\r\n\r\n@w9n does that address the q"; 340273985 w9n: "yes, it pretty much goes is in the right direction. I will read and think about "; 341074173 ijc: "I'm still catching up on my post PTO backlog(s) so I haven't fully grokked this "; 341552432 w9n: "i didnt choose ```foo:latest``` because it can conflict with other contexts. But"; 352289887 w9n: "Since moby became a dependency this works now depending on moby/tool#194 `linuxk"; 355176335 w9n: "@deitch @rn @ijc Please recheck, adopting this could quit manually updating hash"; 355233916 deitch: "I remain torn on this. I think I still like the idea of having the ability to ta"; 355287913 w9n: "> If I understand the implementation correctly, pkg collect would then look in l"; 355293548 ijc: "> if a container has `<latest>` tag\r\n\r\nAre the angle-brackets (`<>`) literally p"; 355298378 w9n: "> Are the angle-brackets (<>) literally part of the tag here or just \"syntax\"?\r\n"; 355304180 deitch: "> Yes, you would need atleast the linuxkit/linuxkit repo and a setup pkgroot par"; 355307237 w9n: "> Are there 2 distinct behaviours?\r\n\r\nThere is `linuxkit pkg collect --pkgroot` "; 355310745 deitch: "> there is linuxkit build -collect which pre-processes and directly outputs the "; 355311332 rn: "`linuxkit pkg collect` seems a misnomer as it is not an operation on a package. "; 355313071 deitch: "> linuxkit pkg collect seems a misnomer as it is not an operation on a package\r\n"; 355314861 rn: "> Yes, but I could see how you might want a convenience of a single step.\r\n\r\nYou"; 355316644 deitch: "> I really do not want linuxkit build to do too much magic. It should just buil"; 355316963 deitch: "On second thought, I guess I can see it. `lkt` already contains all of the code "; 355318030 rn: "sure, this can be done with a shell script. `grep` image patterns and `linuxkit "; 355321845 ijc: "> You get a \"single\" step with linuxkit tranform | linuxkit build -. I really do"; 355347992 w9n: "dropping `linuxkit build -collect` and `--pkgroot <org>:<path>` sounds good to m"; 355446448 rn: "`linuxkit transform -o outputfile <filename> | linuxkit build -` does not seem t"; 355491579 deitch: "> I think generate is my favourite\r\n\r\nI like it too. My only concern is that, t"; 355491607 deitch: "Or perhaps `lkt template`?"; 355492212 w9n: "generate sounds good but dont mind changing.\r\n\r\nChanged to `linuxkit generate --"; 355530363 rn: "@w9n thanks for the quick change, I have a few comments on the implementation it"; 355535990 ijc: "> then a new `linuxkit build` command \r\n\r\nITYM `linuxkit generate`? Not mad enam"; 355538317 ijc: "> My only concern is whether or not there is some existing YAML templating synta"; 355540809 deitch: "> Couldn't find anything\r\n \r\nYeah, I had that issue a while ago. Ended up writi"; 355540982 deitch: "> ITYM linuxkit generate? Not mad enamoured on the name, but no better ideas (ba"; 355567882 w9n: "> you shouldn't need to add anything to pkglib. This is a new top level command "; 355569715 w9n: "bake & build would kind of short and precisely describe whats going on and actua"; 355570963 ijc: "> the git methods are not public \r\n\r\nYou appear to be using them to reimplement "; 355572091 w9n: "Yes `New` in pkglib.Pkg would be awesome - but i think this needs some more work"; 355574550 ijc: "Where/why does this code need to deal with old hashes?\r\n\r\nGenerating the hash co"; 355577199 w9n: "if there is\r\n```\r\ntags:\r\n - name: <2.1>\r\n hash: bb0c6ae2f12a1b55df24ebce2067"; 355577929 rn: "Can we address one issue at a time. templating of the YAML file is one thing and"; 355579842 ijc: "You can already get the package hash from a git tag today already, it's currentl"; 355656944 w9n: "I made `pkgInfo` public and moved it into the config namespace I put GlobalConfi"; 355967540 ijc: "> I made pkgInfo public \r\n\r\nI don't like this, sorry. This struct should remain "; 356205605 w9n: "@ijc I did what you suggested and exposed a `SetCommit` `GetHash` and `Image` fu"; 356250551 ijc: "You shouldn't need `SetCommit` since the only caller outside `pkglib` passes a h"; 356256042 w9n: "done"; 356556345 w9n: "so i rethought this and the whole templating problem might just not fit into lin"; 356567368 ijc: "I don't think there are objections to templating in general, my specific objecti"; 356571088 w9n: "If git tags or parameter like `foo=abcdef` are used than this would require e.g."; 356572786 ijc: "We intend to release linuxkit as a whole, with a single consistent set of packag"; 356576666 rn: "I agree with @ijc that we do want some templating. We had several discussions in"; 356579465 justincormack: "I don't understand what the output of `linuxkit bake example/linuxkit_template.y"; 356581808 ijc: "It's a new file which you can pass to `linuxkit build` (after archiving it for r"; 356582385 justincormack: "Does it output to stdout or what? This needs to be documented properly."; 356582717 w9n: "Okay, so I could live with this somewhere:\r\n```\r\ntags:\r\n - name: v1.0\r\n "; 356585190 rn: "@w9n please read my comment linuxkit/linuxkit#2648 (comment)"; 356587899 w9n: "> Do you have an example for a baked YAML file. It would be useful if it would c"; 356589814 w9n: "i dont really trust the test time, something must be wrong...\r\n```\r\n[+ 24m 58s] "; 356647166 w9n: "@ijc \r\n```\r\nlinuxkit bake -D foo=abcdef foo.yml\r\n```\r\nThis can actually be done "; 356922250 w9n: "updated the last comment, otherwise i guess i should revert setting global confi"; 357164648 w9n: "Sorry for all these changes\r\n - dropped putting GlobalConfig in its own namespac"; 357425907 w9n: "```\r\n[+ 24m 27s] [PASS ] linuxkit.build.examples.bake 32.57s\r\n```\r\n\r\nfixed te"|]} {linuxkit/linuxkit 2742[dd89459e9a7579f0918d01727afa4ff34ce0d283] master deitch open "Keep track of processed ttys and only start same one once" [|0 deitch: "Signed-off-by: Avi Deitcher <[email protected]>\r\n\r\n<!--\r\nPlease make sure you've "; 344683866 deitch: "Pushed out in arm64 and x86"; 355305421 deitch: "This one is open 6 weeks later, can we just take it as is?"; 355305711 justincormack: "I think there was a preference for using files..."; 355306288 deitch: "> I think there was a preference for using files...\r\n\r\nI was neutral, but I kind"|]} {linuxkit/linuxkit 1c552f7a9db7f0660d3c83362d241e54142323ca} {linuxkit/linuxkit 37e29b45b3a5015e846f64ab32dffb7a48c32b3a} {linuxkit/linuxkit 8d17887e11c7ad25efd7f201b8dfe2b0badc4bee} {linuxkit/linuxkit dd89459e9a7579f0918d01727afa4ff34ce0d283} Removed {linuxkit/linuxkit 07470f43b80477003230ec75732994331d8cad93} {linuxkit/linuxkit 0c631d104faf343e8fb81157d81ce09bb2155c75} {linuxkit/linuxkit 14ba30f4183b12baf7dc14e0669487698854aae1} {linuxkit/linuxkit 42397f7f1d48e9fa65546fe4a5c1ef56fe81c99a} {linuxkit/linuxkit 42a0facbbcb061698b26c2ecae7174c24a8886c8} {linuxkit/linuxkit 4ca4f34d457d6a8caf83660de89724cda0fa3076} {linuxkit/linuxkit-ci 5a82742950d7be4b8c0c9d9629684d07bca9fd33} {linuxkit/linuxkit 6290faf022489f2bd8103b060f5530cc2258f651} {linuxkit/linuxkit 6c1ba442b438669e11eefbb53f6ae3abd3fc5dd6} {linuxkit/linuxkit 7451797b94b05e2074bec9f2a90a02d379ab834f} {linuxkit/linuxkit 7a7f5f66c24d205910ef9599286771e94eca5879} {linuxkit/linuxkit 7b0b7dff84687752594004381325c4b091ee5994} {linuxkit/linuxkit 841026d311a46d5853aec1b777dc2b39a5624694} {linuxkit/linuxkit 8a7ba7197e083986b4e1f3f16c3c79346bc6d3e3} {linuxkit/linuxkit 8d5ced3a1dcff6a675e1430ef1829ea5c2e273bf} {linuxkit/linuxkit 9f04f5c97d51aecc941a4449283e4188366d0bb0} {linuxkit/linuxkit a6e37e0c7ed67c81f2f5cb71611458414dcd549c} {linuxkit/linuxkit a9c33ca53371b7f01e8f536f507c95297a073161} {linuxkit/linuxkit b1de3970ae85a3a4cda8690edf97154797c5ec6e} {linuxkit/linuxkit b4a8b9485a2438904e4f3b2cc290de4fbef92c93} {linuxkit/linuxkit b698d26c87f9c172b342d567120ba657f46b876d} {linuxkit/linuxkit bb307079b076a29ec794b599124524a9eebc24a3} {linuxkit/linuxkit bdeaa59e7406f9e810cec5fcd77220fe7fac9de9} {linuxkit/linuxkit c8b81a6ad068e067192ed9f88f97c0eaab6a923f} {linuxkit/linuxkit cad424802477d30a58b08e4fca0f12df7635916b} {linuxkit/linuxkit d5b5f5ba90b7a584c76c678b4e1fda5715ec9fe3} {linuxkit/linuxkit d84aa8542072f72235c85006908ef00631cc0024} {linuxkit/linuxkit d987c058bd7965ed8d5e7aa2d3d11347e55c4fdb} {linuxkit/linuxkit dee3390b34a29290ed18ba8706ddae232a73588b} {linuxkit/linuxkit df0f095d579394f7e7e7e947e4acc2af38ba2c7b} {linuxkit/linuxkit e6b396c44838d6b95e4c1d7268ea3ac21b8af3b2} {linuxkit/linuxkit-ci f2a559e888245a3ab3a561b77b8d3e3609eab16d} {linuxkit/linuxkit fd3809df5baa48d293c6b168e2e1b1521014ffe8}

crosbymichael force-pushed the restart branch from d341ef2 to 6b4ee27 Compare April 30, 2018 21:12

crosbymichael added this to the 1.2 milestone Apr 30, 2018

AkihiroSuda reviewed May 1, 2018

View reviewed changes

Comment thread restart/local/manager.go Outdated

Copy link
Copy Markdown

Member

AkihiroSuda May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use event API?

crosbymichael force-pushed the restart branch 2 times, most recently from 9317031 to 37d6966 Compare May 1, 2018 16:15

crosbymichael force-pushed the restart branch from 37d6966 to b51aa70 Compare May 1, 2018 17:18

dmcgowan reviewed May 1, 2018

View reviewed changes

crosbymichael force-pushed the restart branch from b51aa70 to 31e0052 Compare May 1, 2018 18:01

dmcgowan reviewed May 1, 2018

View reviewed changes

Comment thread services/services.go Outdated

Copy link
Copy Markdown

Member

dmcgowan May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed now

dmcgowan reviewed May 1, 2018

View reviewed changes

crosbymichael force-pushed the restart branch 5 times, most recently from bac22c9 to 0b0d745 Compare May 1, 2018 18:35

dmcgowan reviewed May 1, 2018

View reviewed changes

crosbymichael force-pushed the restart branch 2 times, most recently from b50a746 to 10289e8 Compare May 2, 2018 14:23

Conversation

crosbymichael commented Apr 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmcgowan commented Apr 30, 2018

Uh oh!

crosbymichael commented Apr 30, 2018

Uh oh!

dmcgowan commented Apr 30, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda commented May 1, 2018

Uh oh!

crosbymichael commented May 1, 2018

Uh oh!

crosbymichael commented May 1, 2018

Uh oh!

codecov-io commented May 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Random-Liu commented May 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crosbymichael commented May 2, 2018

Uh oh!

Random-Liu commented May 2, 2018

Uh oh!

crosbymichael commented May 2, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

crosbymichael commented Apr 30, 2018 •

edited

Loading

codecov-io commented May 1, 2018 •

edited

Loading

Random-Liu commented May 2, 2018 •

edited

Loading