Skip to content

update server.go#2317

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
cmingxu:master
May 14, 2018
Merged

update server.go#2317
crosbymichael merged 1 commit intocontainerd:masterfrom
cmingxu:master

Conversation

@cmingxu
Copy link
Copy Markdown
Contributor

@cmingxu cmingxu commented Apr 29, 2018

minor spell change

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 29, 2018 •
edited
Loading

Codecov Report

Merging #2317 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2317   +/-   ##
=======================================
  Coverage   44.98%   44.98%           
=======================================
  Files          92       92           
  Lines        9340     9340           
=======================================
  Hits         4202     4202           
  Misses       4459     4459           
  Partials      679      679
Flag Coverage Δ
#linux 49.28% <ø> (ø) ⬆️
#windows 41.24% <ø> (ø) ⬆️
Impacted Files Coverage Δ
server/server.go 2.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15e7a0...d791232. Read the comment docs.

@ehazlett
Copy link
Copy Markdown
Member

ehazlett commented Apr 30, 2018

LGTM (not maintainer)

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Apr 30, 2018

LGTM but please sign? (git commit --amend -s)

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Apr 30, 2018

@AkihiroSuda how did the CI not catch this?

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Apr 30, 2018 •
edited
Loading

@AkihiroSuda how did the CI not catch this?

Travis didn't run on this PR, haven't seen that before

Good catch @AkihiroSuda, we'll see if the rebase gets picked up

dmcgowan
dmcgowan requested changes Apr 30, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing sign off

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented May 3, 2018

@cmingxu can you please sign your commit and force push the change? If you need more information on what signing your commit means and what the DCO is please look at https://github.com/containerd/containerd/blob/master/CONTRIBUTING.md#sign-your-work

@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented May 3, 2018

A more descriptive commit message would help to :)

@ehazlett
Copy link
Copy Markdown
Member

ehazlett commented May 11, 2018

ping @cmingxu

@cmingxu
Copy link
Copy Markdown
Contributor Author

cmingxu commented May 14, 2018

Thanks for the feedback, commit updated @ehazlett @dmcgowan

estesp
estesp approved these changes May 14, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented May 14, 2018

LGTM

@crosbymichael crosbymichael merged commit b511c39 into containerd:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan requested changes

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cmingxu @codecov-io @ehazlett @AkihiroSuda @crosbymichael @dmcgowan @cpuguy83 @estesp