Add LogFile as a cio IO option#2315
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Apr 27, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2315 +/- ##
=========================================
- Coverage 45.51% 45.41% -0.1%
=========================================
Files 83 83
Lines 9190 9210 +20
=========================================
Hits 4183 4183
- Misses 4331 4351 +20
Partials 676 676
Continue to review full report at Codecov.
|
mlaventure
reviewed
Apr 26, 2018
Contributor
There was a problem hiding this comment.
We don't want to truncate the file? If not maybe say we'll append to it in the docstring
Member
Author
There was a problem hiding this comment.
added. it should be appended so that restarts work
Signed-off-by: Michael Crosby <[email protected]>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Crosby [email protected]