Allow to checkpoint and restore a container with console#2307
Allow to checkpoint and restore a container with console#2307crosbymichael merged 4 commits intocontainerd:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2307 +/- ##
=======================================
Coverage 45.41% 45.41%
=======================================
Files 83 83
Lines 9210 9210
=======================================
Hits 4183 4183
Misses 4351 4351
Partials 676 676
Continue to review full report at Codecov.
|
|
LGTM Nice thanks! I'll add a test for this if you don't have time to add one. |
|
@crosbymichael If you have a test which start a container with console, I think I can write a test by myself. It is my first time, when I'm playing with containerd, and I like this experience. The code base looks nice. |
There was a problem hiding this comment.
Is there a way to block criu from starting the final container process until we signal it?
There was a problem hiding this comment.
@crosbymichael Could you explain the idea of this barrier?
There was a problem hiding this comment.
@crosbymichael I think I understand the problem, will think what we can do.
There was a problem hiding this comment.
It's to mimic the create/start split so there is time after the namespaces and process has been created before the user's process starts.
|
Ok, the existing checkpoint tests are here: And a TTY tests is here so you can use it as a template: |
avagin
force-pushed
the
tty
branch
2 times, most recently
from
956fed9 to
5017b4a
Compare
|
@avagin actually, for now can you move the restore functionality back into the Start method instead of create so that we keep the same API that the process is started when you call start and not when the container is created in the restore case? |
|
@crosbymichael I will try. We are thinking how to split restore and start, but all solutions are not simple, so it's better to do as a separate task. Now I'm going to you move the restore functionality back into the Start method, and we will be able to merge this pull request. |
Signed-off-by: Andrei Vagin <[email protected]>
|
Yep, we are merge when its moved back. |
runc already supports this case, so we just need to run it with proper options. Signed-off-by: Andrei Vagin <[email protected]>
Signed-off-by: Andrei Vagin <[email protected]>
Signed-off-by: Andrei Vagin <[email protected]>
|
LGTM |
4 participants
runc already supports this case, so we just need to run it with proper
options.
Signed-off-by: Andrei Vagin [email protected]