Prepare 1.1.0 release#2302
Conversation
There was a problem hiding this comment.
We are including that by default now, yeah, let's add it
There was a problem hiding this comment.
cri -> containerd/cri, or just "the CRI plugin"?
There was a problem hiding this comment.
@Random-Liu any recommendation? I think maybe the project name containerd/cri is what is intended here
There was a problem hiding this comment.
For clarity, can we mention that cri was formerly cri-containerd?
There was a problem hiding this comment.
The next paragraph mentions the former cri-containerd daemon. Not sure the project rename needs to be mentioned here, since it was just moved from cri-containerd -> containerd/cri. If we feel there is some confusion we can always update the Github part of the release notes later.
Codecov Report
@@ Coverage Diff @@
## master #2302 +/- ##
=======================================
Coverage 45.54% 45.54%
=======================================
Files 83 83
Lines 9185 9185
=======================================
Hits 4183 4183
Misses 4326 4326
Partials 676 676
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Can we clarify that containerd v1.1 uses containerd/cri v1.0?
There was a problem hiding this comment.
I can add a sentence in the support section.
|
LGTM |
There was a problem hiding this comment.
I'll create a branch in cri, and this link should point to that branch. Let's remember to update this.
There was a problem hiding this comment.
Should we point to the tag here? Also is the release branch going to be named release/1.0?
There was a problem hiding this comment.
Yeah, let's point to the tag. And the branch will be release/1.0.
There was a problem hiding this comment.
I've cut the release. Let's update all v1.0 to v1.0.0.
There was a problem hiding this comment.
@Random-Liu I added some wording here about 1.0 and containerd/cri only being supported in containerd 1.1. SGTY?
There was a problem hiding this comment.
I feel like we should try to make user forget about containerd/cri version, all notable new features of containerd/cri are containerd new features, and should be mentioned in and bound to containerd release. The version in containerd/cri is only used to manage the project.
Maybe we should not include cri version here to make it less confusing?
There was a problem hiding this comment.
Can I put a tarball link and sha here? A release tarball for Kubernetes users' convenience, as suggested in containerd/cri#744 (comment)
I can build and upload the tarball after we tag the release, and I'll come back and update the release note here.
I'll manually make sure we use the officially published containerd binaries in the tarball.
There was a problem hiding this comment.
If we can include it here, I won't include it in containerd/cri release note, and it should be less confusing to people.
There was a problem hiding this comment.
Yeah, we can do that. We don't need to update this file then, if it doesn't need to be in the tag and just on Github
There was a problem hiding this comment.
Yeah, it's just on github. I just want to make sure you are fine with that. :)
I'll update the release to include the release tarball.
There was a problem hiding this comment.
Yeah, let's point to the tag. And the branch will be release/1.0.
There was a problem hiding this comment.
I feel like we should try to make user forget about containerd/cri version, all notable new features of containerd/cri are containerd new features, and should be mentioned in and bound to containerd release. The version in containerd/cri is only used to manage the project.
Maybe we should not include cri version here to make it less confusing?
Signed-off-by: Derek McGowan <[email protected]>
|
CRI 1.0 merged, links updated, and rebased |
5 participants
Please review this, make sure the links are correct and everything is included.
Once this is merged, the v1.1.0 tag will be created from the merge commit and the
release/1.1branch will be created from there