[release/1.0] Return a better error message is unix socket path is too long.#2256
Merged
stevvooe merged 1 commit intocontainerd:release/1.0from Mar 30, 2018
Merged
Conversation
Signed-off-by: Kenfe-Mickael Laventure <[email protected]> (cherry picked from commit 3c3a676) Signed-off-by: Stephen J Day <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release/1.0 #2256 +/- ##
============================================
Coverage 50.78% 50.78%
============================================
Files 81 81
Lines 7176 7176
============================================
Hits 3644 3644
Misses 2832 2832
Partials 700 700
Continue to review full report at Codecov.
|
mlaventure
reviewed
Mar 30, 2018
| func CreateUnixSocket(path string) (net.Listener, error) { | ||
| // BSDs have a 104 limit | ||
| if len(path) > 104 { | ||
| return nil, errors.Errorf("%q: unix socket path too long (> 106)", path) |
Contributor
There was a problem hiding this comment.
just realized I have a typo here, 106 != 104 😇
Member
Author
There was a problem hiding this comment.
Can you fix that in another PR and I'll backport that as well?
stevvooe
changed the title
Member
Author
|
@mlaventure We can probably just merge this one and backport the other PR. ;D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kenfe-Mickael Laventure [email protected]
(cherry picked from commit 3c3a676)
Signed-off-by: Stephen J Day [email protected]