[release/1.0] services/content: fix reading a blob which is smaller than the read buffer#2234
Merged
stevvooe merged 2 commits intocontainerd:release/1.0from Mar 27, 2018
Merged
Conversation
…uffer.
The newly added test fails without this fix in services/content/service.go:
$ go test -c . && sudo ./containerd.test -test.v -test.root -test.run TestContentClient
...
--- FAIL: TestContentClient/SmallBlob (0.02s)
provideringester.go:62: rpc error: code = OutOfRange desc = read
past object length 6 bytes
helpers.go:67: drwx------ 4096
/tmp/content-suite-ContentClient-286788688
FAIL
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Stephen J Day <[email protected]> Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
cherry-pick-2221
branch
from
0ca0b6f to
eaee9f5
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.0 #2234 +/- ##
===============================================
+ Coverage 50.55% 50.78% +0.22%
===============================================
Files 81 81
Lines 7176 7176
===============================================
+ Hits 3628 3644 +16
+ Misses 2853 2832 -21
- Partials 695 700 +5
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #2221