[release/1.0] linux/prox: timeout fifo creation#2232
Merged
dmcgowan merged 1 commit intocontainerd:release/1.0from Mar 26, 2018
Merged
[release/1.0] linux/prox: timeout fifo creation#2232dmcgowan merged 1 commit intocontainerd:release/1.0from
dmcgowan merged 1 commit intocontainerd:release/1.0from
Conversation
Under certain conditions in the client, the fifo for a container may not be created. A timeout has been added to this operation to ensure the shim can recover when the client fails to open the fifos. Signed-off-by: Stephen J Day <[email protected]> (cherry picked from commit 9754696) Signed-off-by: Stephen J Day <[email protected]>
Member
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## release/1.0 #2232 +/- ##
============================================
Coverage 50.55% 50.55%
============================================
Files 81 81
Lines 7176 7176
============================================
Hits 3628 3628
Misses 2853 2853
Partials 695 695
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under certain conditions in the client, the fifo for a container may not
be created. A timeout has been added to this operation to ensure the
shim can recover when the client fails to open the fifos.
Signed-off-by: Stephen J Day [email protected]
(cherry picked from commit 9754696)
Signed-off-by: Stephen J Day [email protected]
Cherry pick of #2229 into release/1.0