[release/1.0] socket in archive and gc config fixes#2224
Merged
stevvooe merged 3 commits intocontainerd:release/1.0from Mar 23, 2018
Merged
[release/1.0] socket in archive and gc config fixes#2224stevvooe merged 3 commits intocontainerd:release/1.0from
stevvooe merged 3 commits intocontainerd:release/1.0from
Conversation
The go-tar implementation which is used cannot handle sockets. There's no good reason to preserve a socket, they are basically useless without the process which made them. Signed-off-by: Ian Campbell <[email protected]>
stevvooe
reviewed
Mar 22, 2018
Member
There was a problem hiding this comment.
Needs a comment, which we missed upstream.
Signed-off-by: Derek McGowan <[email protected]>
Signed-off-by: Yanqiang Miao <[email protected]>
dmcgowan
force-pushed
the
backport-archive-gc-fixes
branch
from
3b0a8a4 to
3d34cc0
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.0 #2224 +/- ##
===============================================
- Coverage 50.57% 50.55% -0.03%
===============================================
Files 81 81
Lines 7171 7176 +5
===============================================
+ Hits 3627 3628 +1
- Misses 2849 2853 +4
Partials 695 695
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
Mar 23, 2018
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #2214 and #2222