Faster than I am. My vndr is still running because of the massive k8 deps

Faster than I am. My vndr is still running because of the massive k8 deps

Must be the power of the Lenovo X1 Carbon over the Dell XPS 😆

LGTM

Codecov Report

Merging #2198 into release/1.0 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/1.0    #2198   +/-   ##
============================================
  Coverage        50.57%   50.57%           
============================================
  Files               81       81           
  Lines             7171     7171           
============================================
  Hits              3627     3627           
  Misses            2849     2849           
  Partials           695      695

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4bbcc...5f0a37c. Read the comment docs.

LGTM, but where is the PR to master?

@dmcgowan it's complicated; unless I temporarily have containerd master branch vendor from release/1.0 of containerd/cgroups it is hard to get the licenses and bug fix without picking up the RDMA changes which require an non-tagged/release version of the OCI runtime-spec.

Obviously that should be in place before we do a 1.1 release, but I guess it depends if we want a temporary solution for cgroups vendoring in master before that is solved.

I think we can still use this same commit in master.

I didn't update master with the cgroups change in my last PR.

I think we can still use this same commit in master.

That's reasonable; I will PR master with the same commit we're using for (targeting) 1.0.3 fix branch

#2199 handles this update for master