[release/1.0] linux: fix runtime-root propagation#2194
Merged
crosbymichael merged 2 commits intocontainerd:release/1.0from Mar 9, 2018
Merged
[release/1.0] linux: fix runtime-root propagation#2194crosbymichael merged 2 commits intocontainerd:release/1.0from
crosbymichael merged 2 commits intocontainerd:release/1.0from
Conversation
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
changed the title
AkihiroSuda
reviewed
Mar 8, 2018
Member
There was a problem hiding this comment.
CI failure is due to this unneeded nolint.
Could you remove this nolint from this PR (and also for master)?
kunalkushwaha
force-pushed
the
cherry-pick-runtime-root
branch
from
e36d4e5 to
1549d92
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.0 #2194 +/- ##
============================================
Coverage 50.57% 50.57%
============================================
Files 81 81
Lines 7171 7171
============================================
Hits 3627 3627
Misses 2849 2849
Partials 695 695
Continue to review full report at Codecov.
|
AkihiroSuda
reviewed
Mar 8, 2018
kunalkushwaha
force-pushed
the
cherry-pick-runtime-root
branch
from
1549d92 to
ee089eb
Compare
faf2781 fixed the propagation for ShimRemote but ShimLocal was not fixed in the commit. Signed-off-by: Akihiro Suda <[email protected]> Signed-off-by: Kunal Kushwaha <[email protected]>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kunal Kushwaha [email protected]
Cherry-pick #2173 #2182