Skip to content

Plug-in cri subcommand#2175

Merged
dmcgowan merged 2 commits intocontainerd:masterfrom
Random-Liu:plugin-cri-cli
Mar 14, 2018
Merged

Plug-in cri subcommand#2175
dmcgowan merged 2 commits intocontainerd:masterfrom
Random-Liu:plugin-cri-cli

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

@Random-Liu Random-Liu commented Feb 28, 2018 •
edited
Loading

For containerd/cri#590.

This PR:

  1. Update containerd/cri to 0c87604.
  2. Added cmd/command package for similar purpose with cmd/containerd: split package for cli.App #2131. @containerd/containerd-maintainers I'm not sure whether people are ok with this.
  3. Add ctr cri subcommand, currently only load is needed.

@Random-Liu Random-Liu changed the title [WIP] Plugin cri subcommand [WIP] Plug-in cri subcommand Feb 28, 2018
@Random-Liu Random-Liu force-pushed the plugin-cri-cli branch 2 times, most recently from fb54aba to ef7e8e5 Compare February 28, 2018 21:40
@Random-Liu Random-Liu changed the title [WIP] Plug-in cri subcommand Plug-in cri subcommand Mar 1, 2018
@Random-Liu Random-Liu mentioned this pull request Mar 1, 2018
Closed
9 tasks
@stevvooe stevvooe mentioned this pull request Mar 13, 2018
Closed
@stevvooe stevvooe added this to the 1.1 milestone Mar 13, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 13, 2018

Codecov Report

Merging #2175 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2175   +/-   ##
=======================================
  Coverage   41.19%   41.19%           
=======================================
  Files          66       66           
  Lines        7725     7725           
=======================================
  Hits         3182     3182           
  Misses       4041     4041           
  Partials      502      502
Flag Coverage Δ
#windows 41.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b01099...4799799. Read the comment docs.

@stevvooe
Copy link
Copy Markdown
Member

stevvooe commented Mar 13, 2018

LGTM

@Random-Liu Random-Liu changed the title Plug-in cri subcommand [WIP] Plug-in cri subcommand Mar 13, 2018
@Random-Liu
Copy link
Copy Markdown
Member Author

Random-Liu commented Mar 13, 2018

Mark WIP to wait until the containerd/cri side change gets merged.

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Mar 14, 2018

I'll wait until you update, but also looks good

@Random-Liu Random-Liu changed the title [WIP] Plug-in cri subcommand Plug-in cri subcommand Mar 14, 2018
@Random-Liu
Copy link
Copy Markdown
Member Author

Random-Liu commented Mar 14, 2018

@stevvooe @dmcgowan Done. :)

dmcgowan
dmcgowan approved these changes Mar 14, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 1a930e5 into containerd:master Mar 14, 2018
@Random-Liu Random-Liu deleted the plugin-cri-cli branch March 14, 2018 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

5 participants

@Random-Liu @codecov-io @stevvooe @dmcgowan @AkihiroSuda