linux: propagate --runtime-root to shim properly#2173
Merged
estesp merged 1 commit intocontainerd:masterfrom Feb 28, 2018
Merged
linux: propagate --runtime-root to shim properly#2173estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
fix-shim-runtime-root
branch
from
163f5c7 to
faf2781
Compare
Member
Author
|
Definitely we should have testsuite against several config.tomls (in another PR) |
Codecov Report
@@ Coverage Diff @@
## master #2173 +/- ##
=======================================
Coverage 41.11% 41.11%
=======================================
Files 66 66
Lines 7543 7543
=======================================
Hits 3101 3101
Misses 3961 3961
Partials 481 481
Continue to review full report at Codecov.
|
Member
|
LGTM |
Contributor
|
Should this has been done to In which case I would have moved the logic to |
Member
Author
|
Hmm, probably yes, thank you for pointing out. I'll try to look into |
Member
Author
|
I opened #2182 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akihiro Suda [email protected]
The
runtime_rootoption inconfig.tomlwas not propagated to the shim.