Add client.Reconnect API#2149
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Feb 21, 2018
Merged
Conversation
Member
|
Thanks! This works well, tested in moby/moby. |
cpuguy83
reviewed
Feb 21, 2018
This adds a reconnect api to the client so that the client instance stays the same and on reconnect, all tasks and containers with references to the *Client have the correct connection. Signed-off-by: Michael Crosby <[email protected]>
crosbymichael
force-pushed
the
reconnect
branch
from
32e6028 to
7b653dc
Compare
Member
|
I guess a |
Codecov Report
@@ Coverage Diff @@
## master #2149 +/- ##
==========================================
- Coverage 45.56% 45.53% -0.04%
==========================================
Files 80 80
Lines 8726 8726
==========================================
- Hits 3976 3973 -3
- Misses 4105 4107 +2
- Partials 645 646 +1
Continue to review full report at Codecov.
|
Member
Resolve in this PR? LGTM as is, adding an opt in a follow up seems reasonable and would allow for some interesting flexibility. |
Member
|
SGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a reconnect api to the client so that the client instance
stays the same and on reconnect, all tasks and containers with
references to the *Client have the correct connection.
Signed-off-by: Michael Crosby [email protected]