[release/1.0] archive/diff: fix consecutive directory removal bug#2127
Merged
stevvooe merged 2 commits intocontainerd:release/1.0from Feb 12, 2018
Merged
[release/1.0] archive/diff: fix consecutive directory removal bug#2127stevvooe merged 2 commits intocontainerd:release/1.0from
stevvooe merged 2 commits intocontainerd:release/1.0from
Conversation
Signed-off-by: Derek McGowan <[email protected]>
Fixes a bug where rmdir was not getting set on a directory if the previous change was also a directory. From f3fdbe586829c02f81fc55da62618b5a2b0edc51 in containerd/continuity Signed-off-by: Derek McGowan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release/1.0 #2127 +/- ##
============================================
Coverage 50.56% 50.56%
============================================
Files 81 81
Lines 7169 7169
============================================
Hits 3625 3625
Misses 2849 2849
Partials 695 695
Continue to review full report at Codecov.
|
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of #2126
Since fs package was moved to continuity in master, this creates an identical fix for the fs package in the release/1.0 branch. There has been no functionality divergence since moving from master.