Support trace level.#2106
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Feb 6, 2018
Merged
Conversation
Signed-off-by: Lantao Liu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2106 +/- ##
==========================================
- Coverage 45.35% 45.29% -0.07%
==========================================
Files 95 95
Lines 9448 9461 +13
==========================================
Hits 4285 4285
- Misses 4451 4464 +13
Partials 712 712
Continue to review full report at Codecov.
|
estesp
approved these changes
Feb 6, 2018
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM; This seems totally reasonable to me given the other discussion and the needs of cri-containerd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2028.
I'm not sure whether people are fine about this. Send it here for opinions.
We do need this in cri-containerd. See #2028 (comment)
Signed-off-by: Lantao Liu [email protected]