[release/1.0] Fix vendor validation#2102
Conversation
Shouldn't there be an extra commit for this? |
|
Also, make sure to use |
|
Maybe |
|
the dco check changes are a separate commit, but I can bring in c024da2 if you want me to pull that in as well. I think they can be in a separate PR though. |
Signed-off-by: Daniel Nephin <[email protected]> (cherry picked from commit cc9216c) Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]> (cherry picked from commit 315084f) Signed-off-by: Daniel Nephin <[email protected]>
|
Up to you. you can do it in one pr if there are more vendor changes you have to pick to get this fixed. |
vendor/ must be removed first, otherwise files added to vendor/ that aren't added to vendor.conf will not cause the validation to fail. Signed-off-by: Daniel Nephin <[email protected]> (cherry picked from commit 2125d8e) Signed-off-by: Daniel Nephin <[email protected]>
dnephin
force-pushed
the
fix-vendor-validation
branch
from
47dd1d2 to
043828f
Compare
Signed-off-by: Daniel Nephin <[email protected]>
|
Ok, I think I've got the cherry-pick done correctly now. Adding the vendor check found an error with vendor, so fixed that as well. in the last commit. |
Codecov Report
@@ Coverage Diff @@
## release/1.0 #2102 +/- ##
============================================
Coverage 50.57% 50.57%
============================================
Files 81 81
Lines 7167 7167
============================================
Hits 3625 3625
Misses 2848 2848
Partials 694 694
Continue to review full report at Codecov.
|
|
LGTM |
|
LGTM I have added this to the 1.0.2 milestone, as I believe these are important changes for ensuring quality of the release (ie, vendored imports should match versions). |
4 participants
Backport of #2092
release/1.0 didn't have any vendor validation so I had to backport the change to install vndr as well.