Fix vendor validation#2092
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Feb 2, 2018
Merged
Conversation
vendor/ must be removed first, otherwise files added to vendor/ that aren't added to vendor.conf will not cause the validation to fail. Signed-off-by: Daniel Nephin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2092 +/- ##
=======================================
Coverage 45.37% 45.37%
=======================================
Files 96 96
Lines 9447 9447
=======================================
Hits 4287 4287
Misses 4449 4449
Partials 711 711
Continue to review full report at Codecov.
|
Member
|
LGTM @dnephin Can you backport this to |
Member
|
LGTM |
Contributor
Author
|
will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor/ must be removed first, otherwise files added to vendor/ that aren't added to
vendor.conf will not cause the validation to fail.