Skip to content

release: prepare 1.0.2-rc.0#2074

Merged
dmcgowan merged 1 commit intocontainerd:release/1.0from
stevvooe:prepare-1.0.2-rc.0
Jan 30, 2018
Merged

release: prepare 1.0.2-rc.0#2074
dmcgowan merged 1 commit intocontainerd:release/1.0from
stevvooe:prepare-1.0.2-rc.0

Conversation

@stevvooe
Copy link
Copy Markdown
Member

@stevvooe stevvooe commented Jan 29, 2018

Signed-off-by: Stephen J Day [email protected]

@stevvooe stevvooe added this to the 1.0.2 milestone Jan 29, 2018
@stevvooe
Copy link
Copy Markdown
Member Author

stevvooe commented Jan 29, 2018

If there are critical issues missing from this proposed release, please pipe up!

mlaventure
mlaventure reviewed Jan 29, 2018
View reviewed changes
Comment thread releases/v1.0.2-rc.0.toml Outdated
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure Jan 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe link to the revision or PR from/where which it was fixed since runc still doesn't have releases yet.

Copy link
Copy Markdown
Member Author

@stevvooe stevvooe Jan 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crosbymichael any details here?

Copy link
Copy Markdown
Member

@crosbymichael crosbymichael Jan 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opencontainers/runc#1698

@stevvooe
Copy link
Copy Markdown
Member Author

stevvooe commented Jan 29, 2018

@crosbymichael @mlaventure Make sure that language looks good to you.

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Jan 29, 2018

lgtm

@stevvooe
Copy link
Copy Markdown
Member Author

stevvooe commented Jan 29, 2018

After merging a PR, it looks like we've had a flaky unit test:

   --- FAIL: TestContentClient/Resume (0.03s)
        testsuite.go:189: compare update 2018-01-29 21:54:59.543512701 +0000 UTC against (2018-01-29 21:54:59.543229762 +0000 UTC m=+7.228369432, 2018-01-29 21:54:59.543751838 +0000 UTC m=+7.228891491)
        testsuite.go:198: compare update 2018-01-29 21:54:59.543512701 +0000 UTC against (2018-01-29 21:54:59.543229762 +0000 UTC m=+7.228369432, 2018-01-29 21:54:59.543751838 +0000 UTC m=+7.228891491)
        testsuite.go:206: compare update 2018-01-29 21:54:59.554803888 +0000 UTC against (2018-01-29 21:54:59.554625177 +0000 UTC m=+7.239764872, 2018-01-29 21:54:59.55499843 +0000 UTC m=+7.240138089)
        testsuite.go:221: Check info failed: not found
            github.com/containerd/containerd/errdefs.init
                /home/travis/gopath/src/github.com/containerd/containerd/errdefs/errors.go:25
            github.com/containerd/containerd/content.init
                <autogenerated>:1
            github.com/containerd/containerd.init
                <autogenerated>:1
            main.init
                <autogenerated>:1
            runtime.main
                /home/travis/.gimme/versions/go1.9.2.linux.amd64/src/runtime/proc.go:183
            runtime.goexit
                /home/travis/.gimme/versions/go1.9.2.linux.amd64/src/runtime/asm_amd64.s:2337
            content digest sha256:daec4241907ca188cedc84c1efc664ef5a0989820fe22de189c6e219603932d5
            github.com/containerd/containerd/errdefs.FromGRPC
                /home/travis/gopath/src/github.com/containerd/containerd/errdefs/grpc.go:82
            github.com/containerd/containerd.(*remoteContent).Info
                /home/travis/gopath/src/github.com/containerd/containerd/content_store.go:30
            github.com/containerd/containerd/content/testsuite.checkInfo
                /home/travis/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:514
            github.com/containerd/containerd/content/testsuite.checkResumeWriter
                /home/travis/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:220
            github.com/containerd/containerd/content/testsuite.makeTest.func1
                /home/travis/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:57
            testing.tRunner
                /home/travis/.gimme/versions/go1.9.2.linux.amd64/src/testing/testing.go:746
            runtime.goexit
                /home/travis/.gimme/versions/go1.9.2.linux.amd64/src/runtime/asm_amd64.s:2337
            failed to get info
            github.com/containerd/containerd/content/testsuite.checkInfo
                /home/travis/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:516
            github.com/containerd/containerd/content/testsuite.checkResumeWriter
                /home/travis/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:220
            github.com/containerd/containerd/content/testsuite.makeTest.func1
                /home/travis/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:57
            testing.tRunner
                /home/travis/.gimme/versions/go1.9.2.linux.amd64/src/testing/testing.go:746
            runtime.goexit
                /home/travis/.gimme/versions/go1.9.2.linux.amd64/src/runtime/asm_amd64.s:2337

We are going to look at the impact of this failure on this release and work from there.

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Jan 29, 2018

This is new, i saw it once today so probably something merged in the last few days

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 29, 2018 •
edited
Loading

Codecov Report

Merging #2074 into release/1.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.0    #2074   +/-   ##
============================================
  Coverage        50.57%   50.57%           
============================================
  Files               81       81           
  Lines             7167     7167           
============================================
  Hits              3625     3625           
  Misses            2848     2848           
  Partials           694      694
Flag Coverage Δ
#linux 50.57% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17f5b8...a67e9d2. Read the comment docs.

@stevvooe
Copy link
Copy Markdown
Member Author

stevvooe commented Jan 29, 2018

@crosbymichael I am pretty certain this is #2072.

@stevvooe
Copy link
Copy Markdown
Member Author

stevvooe commented Jan 29, 2018

@crosbymichael @dmcgowan #2076 fixes this. It is not critical to backport, but it would be good to backport to ensure integration tests are clean.

@stevvooe
Copy link
Copy Markdown
Member Author

stevvooe commented Jan 30, 2018

Ok, so #2076 works to fix this. It stabilizes the test content generation function and adds a lease to the content tests to ensure that content doesn't get garbage collected during the test run.

I am recommending we backport it to maintain stable integration tests that don't have flaky tests like this.

AkihiroSuda
AkihiroSuda reviewed Jan 30, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you mention the tar fix as well?
#2063

@estesp
Copy link
Copy Markdown
Member

estesp commented Jan 30, 2018

I am recommending we backport it to maintain stable integration tests that don't have flaky tests like this.

Makes sense to me; I've cherrypicked it into #2077 if others agree

@mlaventure
Copy link
Copy Markdown
Contributor

mlaventure commented Jan 30, 2018

@stevvooe updated language lgtm.

@stevvooe
release: prepare 1.0.2-rc.0
a67e9d2 
Signed-off-by: Stephen J Day <[email protected]>
@stevvooe
Copy link
Copy Markdown
Member Author

stevvooe commented Jan 30, 2018

@mlaventure @estesp @AkihiroSuda Updated. PTAL.

estesp
estesp approved these changes Jan 30, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan
Copy link
Copy Markdown
Member

dmcgowan commented Jan 30, 2018

LGTM

@dmcgowan dmcgowan merged commit 8b098d0 into containerd:release/1.0 Jan 30, 2018
@stevvooe stevvooe deleted the prepare-1.0.2-rc.0 branch January 30, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crosbymichael crosbymichael crosbymichael left review comments

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

@mlaventure mlaventure mlaventure left review comments

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.2

Development

Successfully merging this pull request may close these issues.

7 participants

@stevvooe @crosbymichael @codecov-io @estesp @mlaventure @dmcgowan @AkihiroSuda