content: update copy to discard instead of truncate#2065
Merged
estesp merged 2 commits intocontainerd:masterfrom Jan 29, 2018
Merged
content: update copy to discard instead of truncate#2065estesp merged 2 commits intocontainerd:masterfrom
estesp merged 2 commits intocontainerd:masterfrom
Conversation
dmcgowan
force-pushed
the
content-discard-over-truncate
branch
from
b5393c9 to
913c221
Compare
Closed
stevvooe
reviewed
Jan 26, 2018
dmcgowan
force-pushed
the
content-discard-over-truncate
branch
from
913c221 to
d0b2de1
Compare
Signed-off-by: Derek McGowan <[email protected]>
Prevents the copy method from calling discard on the writer when the reader is not seekable. Instead, the copy method will discard up to the offset. Truncate is a more expensive operation since any bytes that are truncated already have their hash calculated and are stored on disk in the backend. Re-writing bytes which were truncated requires transfering the data over GRPC again and re-computing the hash up to the point of truncation. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
content-discard-over-truncate
branch
from
d0b2de1 to
a12f493
Compare
Member
|
LGTM Make sure to backport this to 1.0 branch. |
Codecov Report
@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
- Coverage 45.44% 45.43% -0.01%
==========================================
Files 96 96
Lines 9432 9436 +4
==========================================
+ Hits 4286 4287 +1
- Misses 4436 4438 +2
- Partials 710 711 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the copy method from calling discard on the writer when the reader is not seekable. Instead, the copy method will discard up to the offset. Truncate is a more expensive operation since any bytes that are truncated already have their hash calculated and are stored on disk in the backend. Re-writing bytes which were truncated requires transfering the data over GRPC again and re-computing the hash up to the point of truncation.