Fix duplicate directories entries on metadata change#2054
Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom Jan 25, 2018
Merged
Fix duplicate directories entries on metadata change#2054AkihiroSuda merged 1 commit intocontainerd:masterfrom
AkihiroSuda merged 1 commit intocontainerd:masterfrom
Conversation
Currently directory changes are not added to the list of included directories, allowing those directories to receive duplicate entries where there is both a metadata change to the directory and a change to a file under that directory. Signed-off-by: Derek McGowan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2054 +/- ##
==========================================
- Coverage 50.35% 45.44% -4.92%
==========================================
Files 84 96 +12
Lines 7393 9432 +2039
==========================================
+ Hits 3723 4286 +563
- Misses 2964 4436 +1472
- Partials 706 710 +4
Continue to review full report at Codecov.
|
Member
|
LGTM |
AkihiroSuda
approved these changes
Jan 25, 2018
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently directory changes are not added to the list of included directories, allowing those directories to receive duplicate entries where there is both a metadata change to the directory and a change to a file under that directory.
Adding this for cherry-pick, this could be considered a regression in 1.0.1 since 1.0 would have had the correct behavior by not including the directory as a parent. Note this only effects created content, the main consumer of which right now is buildkit or other build tools using containerd.
See moby/buildkit#266