content.Fetch: better error when auth fails#2052
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Jan 24, 2018
Merged
Conversation
Signed-off-by: Darren Stahl <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2052 +/- ##
==========================================
+ Coverage 45.42% 45.43% +0.01%
==========================================
Files 96 96
Lines 9427 9429 +2
==========================================
+ Hits 4282 4284 +2
Misses 4435 4435
Partials 710 710
Continue to review full report at Codecov.
|
Member
|
LGTM @dmcgowan PTAL |
Member
|
LGTM |
jonnystoten
added a commit
to jonnystoten/containerd
that referenced
this pull request
Jul 27, 2022
For consistency with pulls, see containerd#2052. Signed-off-by: Jonny Stoten <[email protected]>
kiashok
pushed a commit
to kiashok/containerd
that referenced
this pull request
Oct 23, 2024
For consistency with pulls, see containerd#2052. Signed-off-by: Jonny Stoten <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was debugging why I was getting a token auth failure when attempting to pull an image, @jessvalarezo realized that the image was just misspelled.
This adds extra error context when the failure is caused by failed auth to indicate that the repository just might not exist.
cc @stevvooe FYI this was what I thought was a failed token auth. Just a misunderstanding 😄
Signed-off-by: Darren Stahl [email protected]