Update runc to 9f9c96235cc97674e935002fc3d78361b69#2048
Update runc to 9f9c96235cc97674e935002fc3d78361b69#2048crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
This fixes issues for init and exec hanging forever when an error happends on start. Signed-off-by: Michael Crosby <[email protected]>
| } | ||
|
|
||
| // GetSubreaper returns the subreaper setting for the calling process | ||
| func GetSubreaper() (int, error) { |
There was a problem hiding this comment.
Same question: How does this fix work? Is this function called somewhere?
There was a problem hiding this comment.
its called in runc
|
LGTM |
|
For the record, this pulls in opencontainers/runc#1698 as the fix. This is not reflected in the vendored files because this is purely a runc bug that affect binary builds of runc. |
|
The travis errors was from runc not being a static build. I don't see anything in the diff that would have made this change but maybe something within the travis distro was removed and we are missing a lib. |
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
=======================================
Coverage 45.46% 45.46%
=======================================
Files 96 96
Lines 9401 9401
=======================================
Hits 4274 4274
Misses 4417 4417
Partials 710 710
Continue to review full report at Codecov.
|
|
@estesp ok, good to review again |
4 participants
This fixes issues for init and exec hanging forever when an error
happens on start.
Fixes #1882
Signed-off-by: Michael Crosby [email protected]