Provide better error context on resolve failures#2011
Merged
estesp merged 1 commit intocontainerd:masterfrom Jan 17, 2018
Merged
Provide better error context on resolve failures#2011estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
AkihiroSuda
reviewed
Jan 17, 2018
Member
There was a problem hiding this comment.
nit: maybe errors.Wrapf(err, "failed to get fetcher for %q", name)
AkihiroSuda
reviewed
Jan 17, 2018
Member
There was a problem hiding this comment.
nit: errors.Wrapf(err, "failed to unpack image on snapshotter %s", pullCtx.Snapshotter)?
Codecov Report
@@ Coverage Diff @@
## master #2011 +/- ##
==========================================
+ Coverage 45.45% 45.48% +0.03%
==========================================
Files 94 94
Lines 9315 9315
==========================================
+ Hits 4234 4237 +3
+ Misses 4372 4370 -2
+ Partials 709 708 -1
Continue to review full report at Codecov.
|
Member
|
I think @AkihiroSuda's added info is useful for more clarity; other than that, looks good |
Signed-off-by: Darren Stahl <[email protected]>
darstahl
force-pushed
the
ResolveErrors
branch
from
cc5e4da to
1338a4f
Compare
Contributor
Author
|
Changes sound good to me. Updated with extra context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging a failure to resolve Windows multi-manifested images, I found more context on the errors in resolve to be necessary. This adds that context on which operation is failing.
for example:
Signed-off-by: Darren Stahl [email protected]