release: prepare 1.0.1#2010
Merged
stevvooe merged 1 commit intocontainerd:release/1.0from Jan 17, 2018
Merged
Conversation
Signed-off-by: Stephen J Day <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release/1.0 #2010 +/- ##
============================================
Coverage 50.59% 50.59%
============================================
Files 81 81
Lines 7137 7137
============================================
Hits 3611 3611
Misses 2835 2835
Partials 691 691
Continue to review full report at Codecov.
|
|
|
||
| // Version holds the complete version number. Filled in at linking time. | ||
| Version = "1.0.1-rc.0+unknown" | ||
| Version = "1.0.1+unknown" |
Member
There was a problem hiding this comment.
is this supposed to keep the -unknown? Probably a stupid question but just thought I would double check.
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
The goal of keeping this with +unknown is so that builds done without the linker injection are easily identified.
Member
|
LGTM Will let @stevvooe merge when ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen J Day [email protected]