[release/1.0] fix running a container with config.User#2005
Merged
estesp merged 4 commits intocontainerd:release/1.0from Jan 16, 2018
Merged
[release/1.0] fix running a container with config.User#2005estesp merged 4 commits intocontainerd:release/1.0from
estesp merged 4 commits intocontainerd:release/1.0from
Conversation
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release/1.0 #2005 +/- ##
===============================================
+ Coverage 50.57% 50.59% +0.02%
===============================================
Files 81 81
Lines 7140 7137 -3
===============================================
Hits 3611 3611
+ Misses 2838 2835 -3
Partials 691 691
Continue to review full report at Codecov.
|
Member
|
LGTM |
Member
|
I just wanted to note that we don't typically backport bugs in |
Member
|
Also, we had said here that this would not go into 1.0.1. |
Member
|
Also, this didn't need 4 commits. |
Member
Author
|
@stevvooe sorry 😅 I'll try to be more careful next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick: #1994