archive: check whiteout path before removal#2001
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Jan 12, 2018
Merged
archive: check whiteout path before removal#2001crosbymichael merged 1 commit intocontainerd:masterfrom
crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
AkihiroSuda
reviewed
Jan 12, 2018
Member
There was a problem hiding this comment.
nit: Wrapf(invalidArchive, "invalid whiteout name: %q", originalPath)?
Ensure whiteout is not pointing to the current directory or parent directory before removing. Protects against invalid removal of the parent or current directory. Add whiteout related tar tests using manufactured tar conditions. Signed-off-by: Derek McGowan <[email protected]>
dmcgowan
force-pushed
the
fix-whiteout-rootpath
branch
from
f1cf89f to
384d46d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2001 +/- ##
==========================================
+ Coverage 45.57% 45.57% +<.01%
==========================================
Files 94 94
Lines 9288 9296 +8
==========================================
+ Hits 4233 4237 +4
- Misses 4347 4351 +4
Partials 708 708
Continue to review full report at Codecov.
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure whiteout is not pointing to the current directory or parent directory before removing. Protects against invalid removal of the parent or current directory.
Add whiteout related tar tests using manufactured tar conditions.
credit to @tonistiigi for finding